Skip to contentSkip to conversation

dlm: Don't delete misc device if lockspace removal fails

PATCH New Patrick Caulfield 2 participants 2 messages Mar 21, 2007 – Mar 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dlm: Don't delete misc device if lockspace removal fails

Currently if the lockspace removal fails the misc device associated with a lockspace is left deleted. After that there is no way to access the orphaned lockspace from userland.

This patch recreates the misc device if th dlm_release_lockspace fails. I believe this is better than attempting to remove the lockspace first because that leaves an unattached device lying around. The potential gap in which there is no access to the lockspace between removing the misc device and recreating it is acceptable ... after all the application is trying to remove it, and only new users of the lockspace will be affected.

Signature · 9 lines
patrick

-------------- next part --------------
A non-text attachment was scrubbed...
Name: device.patch
Type: text/x-patch
Size: 2438 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070321/bd75c92b/attachment.bin>
#1 lore raw

PATCH 1/1 dlm: Don't delete misc device if lockspace removal fails

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

Quoted 12 lines · Patrick Caulfield

Currently if the lockspace removal fails the misc device associated with a lockspace is left deleted. After that there is no way to access the orphaned lockspace from userland.

This patch recreates the misc device if th dlm_release_lockspace fails. I believe this is better than attempting to remove the lockspace first because that leaves an unattached device lying around. The potential gap in which there is no access to the lockspace between removing the misc device and recreating it is acceptable ... after all the application is trying to remove it, and only new users of the lockspace will be affected.