Skip to contentSkip to conversation

dlm: fix coverity-spotted stupidity

PATCH In review Patrick Caulfield 3 participants 7 messages Mar 22, 2007 – Mar 26, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Patrick Caulfield

author
#1 lore raw

PATCH 1/1 dlm: fix coverity-spotted stupidity

This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works. Thanks to Adrian Bunk & the coverity checker for spotting that

Signed-off-by Patrick Caulfield <[email protected]>
Signature · 8 lines
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ret.patch
Type: text/x-patch
Size: 480 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070322/2e513022/attachment.bin>
#2 lore raw

Hi,

Now applied to the -nmw git tree. Thanks,

Steve.

Quoted 5 lines · Patrick Caulfield

This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works. Thanks to Adrian Bunk & the coverity checker for spotting that

Signed-off-by Patrick Caulfield <[email protected]>
#3 lore raw
Quoted 14 lines · Steven Whitehouse

Hi,

Now applied to the -nmw git tree. Thanks,

Steve.

Quoted 5 lines · Patrick Caulfield

This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works. Thanks to Adrian Bunk & the coverity checker for spotting that

Signed-off-by Patrick Caulfield <[email protected]>

Hi,
I pulled this patch along with the latest stuff from the nmw tree. Looks like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart clvmd and such. I'm guessing the kernel_recvmsg() keeps returning -EAGAIN and we keep rescheduling. Any clue as to what is going on? Thanks,
--Abhi

author
#4 lore raw
Quoted 15 lines · Abhijith Das
Quoted 13 lines · Steven Whitehouse

Hi,

Now applied to the -nmw git tree. Thanks,

Steve.

Quoted 4 lines · Patrick Caulfield

This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works.
Thanks to Adrian Bunk & the coverity checker for spotting that

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Patrick Caulfield <[email protected]>

Hi,
I pulled this patch along with the latest stuff from the nmw tree. Looks like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart clvmd and such. I'm guessing the kernel_recvmsg() keeps returning -EAGAIN and we keep rescheduling. Any clue as to what is going on?

Bugger. You're right.

Signature · 1 line
patrick
#5 lore raw

Hi,

Since I'm just updating the git tree due to 2.6.21-rc5, I've pulled this patch for now,

Steve.

Quoted 27 lines · Patrick Caulfield
Quoted 15 lines · Abhijith Das
Quoted 13 lines · Steven Whitehouse

Hi,

Now applied to the -nmw git tree. Thanks,

Steve.

Quoted 4 lines · Patrick Caulfield

This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works.
Thanks to Adrian Bunk & the coverity checker for spotting that

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Patrick Caulfield <[email protected]>

Hi,
I pulled this patch along with the latest stuff from the nmw tree. Looks like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart clvmd and such. I'm guessing the kernel_recvmsg() keeps returning -EAGAIN and we keep rescheduling. Any clue as to what is going on?

Bugger. You're right.

author
#6 lore raw
In reply to Patrick Caulfield

Replacement patch to remove redundant code rather than moving it around.

Signed-off-by Patrick Caulfield <[email protected]>
Signature · 8 lines
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: again.patch
Type: text/x-patch
Size: 342 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070326/3ffcf0e3/attachment.bin>