dvb: remove coding style comments on indentation
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
Regards,
Mike Krufky
Quoted 142 lines
Signed-off-by Charles Clément <[email protected]>---
Index:linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bt832.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c(quoted diff) +0
-8@@ -255,11 +255,3 @@ static void __exit bt832_cleanup_module( module_init(bt832_init_module); module_exit(bt832_cleanup_module); - -/* - * Overrides for Emacs so that we follow Linus's tabbing style. - * --------------------------------------------------------------------------- - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-cards.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c(quoted diff) +0
-7@@ -5044,10 +5044,3 @@ int __devinit bttv_handle_chipset(struct pci_write_config_byte(btv->c.pci, PCI_LATENCY_TIMER, latency); return 0; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-driver.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c(quoted diff) +0
-6@@ -4981,9 +4981,3 @@ static void bttv_cleanup_module(void) module_init(bttv_init_module); module_exit(bttv_cleanup_module); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-gpio.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c(quoted diff) +0
-6@@ -186,9 +186,3 @@ void bttv_gpio_bits(struct bttv_core *co spin_unlock_irqrestore(&btv->gpio_lock,flags); } EXPORT_SYMBOL(bttv_gpio_bits); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h(quoted diff) +0
-5@@ -355,8 +355,3 @@ extern void bttv_input_fini(struct bttv extern void bttv_input_irq(struct bttv *dev); #endif /* _BTTV_H_ */ -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-i2c.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c(quoted diff) +0
-6@@ -481,9 +481,3 @@ int __devexit fini_bttv_i2c(struct bttv return i2c_del_adapter(&btv->c.i2c_adap); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-if.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c(quoted diff) +0
-6@@ -151,9 +151,3 @@ void bttv_i2c_call(unsigned int card, un return; bttv_call_i2c_clients(&bttvs[card], cmd, arg); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-input.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c(quoted diff) +0
-7@@ -348,10 +348,3 @@ void bttv_input_fini(struct bttv *btv) kfree(btv->remote); btv->remote = NULL; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttvp.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h(quoted diff) +0
-6@@ -469,9 +469,3 @@ extern struct bttv bttvs[BTTV_MAX]; #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr) #endif /* _BTTVP_H_ */ - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-risc.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c(quoted diff) +0
-6@@ -894,9 +894,3 @@ bttv_overlay_risc(struct bttv *btv, buf->vb.field = ov->field; return 0; } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c=================================> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-vbi.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c
Review bttv_vbi_fmt_reset (struct bttv_vbi_fmt · line 455
Quoted 10 lines
(quoted diff) +0
-7@@ -446,10 +446,3 @@ bttv_vbi_fmt_reset (struct bttv_vbi_fmt /* See bttv_vbi_fmt_set(). */ f->end = tvnorm->vbistart[0] * 2 + 2; } - -/* ----------------------------------------------------------------------- */ -/* - * Local variables: - * c-basic-offset: 8 - * End: - */
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 5 lines · Michael Krufky
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
I don't know.
Adding "c-indent-tabs-mode: t" is probably even better.
Bernd
Signature · 8 lines
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitorsQuoted 10 lines · Bernd Petrovitsch
Quoted 4 lines · Michael Krufky
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
I don't know.
Adding "c-indent-tabs-mode: t" is probably even better.
Then, in my opinion, it would be better to submit a patch that makes that change, instead of removing them altogether.
Regards,
Mike Krufky
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 9 lines · Michael Krufky
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
Regards,
Mike Krufky
I agree that there is no benefit from the patch itself, but the Documentation/CodingStyle file already specifies the tabbing style. I do not think it should be included in multiple source files.
Quoted 156 lines
Quoted 141 lines
Signed-off-by Charles Clément <[email protected]>---
Index:linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bt832.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c(quoted diff) +0
-8@@ -255,11 +255,3 @@ static void __exit bt832_cleanup_module( module_init(bt832_init_module); module_exit(bt832_cleanup_module); - -/* - * Overrides for Emacs so that we follow Linus's tabbing style. - * --------------------------------------------------------------------------- - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-cards.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c(quoted diff) +0
-7@@ -5044,10 +5044,3 @@ int __devinit bttv_handle_chipset(struct pci_write_config_byte(btv->c.pci, PCI_LATENCY_TIMER, latency); return 0; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-driver.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c(quoted diff) +0
-6@@ -4981,9 +4981,3 @@ static void bttv_cleanup_module(void) module_init(bttv_init_module); module_exit(bttv_cleanup_module); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-gpio.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c(quoted diff) +0
-6@@ -186,9 +186,3 @@ void bttv_gpio_bits(struct bttv_core *co spin_unlock_irqrestore(&btv->gpio_lock,flags); } EXPORT_SYMBOL(bttv_gpio_bits); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h(quoted diff) +0
-5@@ -355,8 +355,3 @@ extern void bttv_input_fini(struct bttv extern void bttv_input_irq(struct bttv *dev); #endif /* _BTTV_H_ */ -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-i2c.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c(quoted diff) +0
-6@@ -481,9 +481,3 @@ int __devexit fini_bttv_i2c(struct bttv return i2c_del_adapter(&btv->c.i2c_adap); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-if.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c(quoted diff) +0
-6@@ -151,9 +151,3 @@ void bttv_i2c_call(unsigned int card, un return; bttv_call_i2c_clients(&bttvs[card], cmd, arg); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-input.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c(quoted diff) +0
-7@@ -348,10 +348,3 @@ void bttv_input_fini(struct bttv *btv) kfree(btv->remote); btv->remote = NULL; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttvp.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h(quoted diff) +0
-6@@ -469,9 +469,3 @@ extern struct bttv bttvs[BTTV_MAX]; #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr) #endif /* _BTTVP_H_ */ - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-risc.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c(quoted diff) +0
-6@@ -894,9 +894,3 @@ bttv_overlay_risc(struct bttv *btv, buf->vb.field = ov->field; return 0; } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c=================================> > ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-vbi.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.cReview bttv_vbi_fmt_reset (struct bttv_vbi_fmt · line 455
Quoted 10 lines
(quoted diff) +0
-7@@ -446,10 +446,3 @@ bttv_vbi_fmt_reset (struct bttv_vbi_fmt /* See bttv_vbi_fmt_set(). */ f->end = tvnorm->vbistart[0] * 2 + 2; } - -/* ----------------------------------------------------------------------- */ -/* - * Local variables: - * c-basic-offset: 8 - * End: - */_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Signature · 5 lines
Charles Clément. _______________________________________________ Kernel-janitors mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
The setting I know is called indent-tabs-mode, not c-indent-tabs-mode. It's also not better or worse than c-basic-offset; it's complementary. The following all work together:
1. indent-tabs-mode if not nil instructs emacs to fill with tab characters where it can. If this setting it nil, indentation is done only with space characters.
2. c-basic-offset specifies the number of columns to indent by - independant of how / if tabs are being used.
3. tab-width specifies the number of columns defined by a tab character.
Thus for (a contrived) example, if you did this:
indent-tabs-mode t
c-basic-offset 4
tab-width 8
Then every indentation level is 4 columns, and tabs will be used wherever 8 columns of total indentation can be combined. Said another way, the first level of indentation would be 4 spaces, the next level would be 1 tab, the next level would be 1 tab plus 4 spaces, etc.
Obviously that is probably not what anyone would want, but it should illustrate the relationship among those settings. So just "eliminating" c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish what one might expect.
I think it's good form to have all those settings in a source file (with c-basic-offset set to 8 not four like the example above). It's not redundant with the documented style. It causes anyone who loads the file with emacs to automatically adopt the indentation conventions intended for that source file and that has to be a good thing.
I for one work in environments other than v4l-dvb, and those other environments don't always have the same coding style. To me it makes perfect sense that the coding style can be encoded into the source file itself. Then I don't have to worry about manually reconfiguring my editor setup when moving in/out of v4l-dvb work. One can argue against this sort of thing (i.e. I should just worry about this myself and always manually switch), but then you're just opening the door for more indentation accidents in the future. I would much prefer these sorts of things to be in the source file; at least this way it helps to ensure others (who use emacs) will automatically use the same indentation that is already in the file.
-Mike
Quoted 24 lines · Michael Krufky
Quoted 10 lines · Bernd Petrovitsch
Quoted 4 lines · Michael Krufky
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
I don't know.
Adding "c-indent-tabs-mode: t" is probably even better.
Then, in my opinion, it would be better to submit a patch that makes that change, instead of removing them altogether.
Regards,
Mike Krufky
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Signature · 4 lines
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 6 lines · Charles Clément
Quoted 5 lines · Michael Krufky
Quoted 1 line · Charles Clément
Remove comments on setting indentation for emacs in bt8xx driver.
What do we gain by this patch? The "c-basic-offset: 8" helps us to enforce tabbing style. Why would anybody want this removed?
Quoted 8 lines
Quoted 3 lines
Regards,
Mike Krufky
I agree that there is no benefit from the patch itself, but the
Documentation/CodingStylefile already specifies the tabbing style. I do not think it should be included in multiple source files.
Documentation/CodingStyle is the human-readable file that specifies the codingstyle, but when I have bttv-cards.c open in emacs, the only thing telling emacs to enforce codingstyle is the lines that you want to remove. Emacs doesn't look to Documentation/CodingStyle for formatting rules -- only people look there. I dont think it causes any harm to keep these lines in the bottom of a source file -- I'm against this removal.
-Michael Krufky
Quoted 147 lines
Quoted 147 lines
Quoted 147 lines
Signed-off-by Charles Clément <[email protected]>---
Index:linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bt832.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c(quoted diff) +0
-8@@ -255,11 +255,3 @@ static void __exit bt832_cleanup_module( module_init(bt832_init_module); module_exit(bt832_cleanup_module); - -/* - * Overrides for Emacs so that we follow Linus's tabbing style. - * --------------------------------------------------------------------------- - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-cards.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c(quoted diff) +0
-7@@ -5044,10 +5044,3 @@ int __devinit bttv_handle_chipset(struct pci_write_config_byte(btv->c.pci, PCI_LATENCY_TIMER, latency); return 0; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-driver.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c(quoted diff) +0
-6@@ -4981,9 +4981,3 @@ static void bttv_cleanup_module(void) module_init(bttv_init_module); module_exit(bttv_cleanup_module); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-gpio.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c(quoted diff) +0
-6@@ -186,9 +186,3 @@ void bttv_gpio_bits(struct bttv_core *co spin_unlock_irqrestore(&btv->gpio_lock,flags); } EXPORT_SYMBOL(bttv_gpio_bits); - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h(quoted diff) +0
-5@@ -355,8 +355,3 @@ extern void bttv_input_fini(struct bttv extern void bttv_input_irq(struct bttv *dev); #endif /* _BTTV_H_ */ -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-i2c.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c(quoted diff) +0
-6@@ -481,9 +481,3 @@ int __devexit fini_bttv_i2c(struct bttv return i2c_del_adapter(&btv->c.i2c_adap); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-if.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c(quoted diff) +0
-6@@ -151,9 +151,3 @@ void bttv_i2c_call(unsigned int card, un return; bttv_call_i2c_clients(&bttvs[card], cmd, arg); } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-input.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c(quoted diff) +0
-7@@ -348,10 +348,3 @@ void bttv_input_fini(struct bttv *btv) kfree(btv->remote); btv->remote = NULL; } - - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttvp.h+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h(quoted diff) +0
-6@@ -469,9 +469,3 @@ extern struct bttv bttvs[BTTV_MAX]; #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr) #endif /* _BTTVP_H_ */ - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-risc.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c(quoted diff) +0
-6@@ -894,9 +894,3 @@ bttv_overlay_risc(struct bttv *btv, buf->vb.field = ov->field; return 0; } - -/* - * Local variables: - * c-basic-offset: 8 - * End: - */Index:
linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c=================================>>> ---linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-vbi.c+++linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c(quoted diff) +0
-4@@ -446,10 +446,3 @@ bttv_vbi_fmt_reset (struct bttv_vbi_fmt /* See bttv_vbi_fmt_set(). */ f->end = tvnorm->vbistart[0] * 2 + 2; } - -/* ----------------------------------------------------------------------- */ -/* - * Local variables:
Quoted 9 lines
Quoted 8 lines
Review bttv_vbi_fmt_reset (struct bttv_vbi_fmt · line 455
Quoted 4 lines
(quoted diff) +0
-3- * c-basic-offset: 8 - * End: - */_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 1 line · Mike Isely
The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
It seems to me that they aer somwhat similar, If I read
http://www.emacswiki.org/cgi-bin/wiki/IndentingC.
Quoted 2 lines
It's also not better or worse than c-basic-offset; it's complementary. The following all work together:
[ ... concise description deleted ...]
Quoted 3 lines
illustrate the relationship among those settings. So just "eliminating" c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish what one might expect.
Sorry, I never meant replacing but adding it to enforce the CodingStyle. And adding "tab-width: 8" is also not wrong (and *if* there is a correct default value for tab-width:, it is IMHO 8).
Quoted 2 lines
I think it's good form to have all those settings in a source file (with c-basic-offset set to 8 not four like the example above). It's not
/me too.
Quoted 8 lines
redundant with the documented style. It causes anyone who loads the file with emacs to automatically adopt the indentation conventions intended for that source file and that has to be a good thing.
I for one work in environments other than v4l-dvb, and those other environments don't always have the same coding style. To me it makes perfect sense that the coding style can be encoded into the source file itself. Then I don't have to worry about manually reconfiguring my
Yup. Actually vi/vim supports similar annotations.
Bernd
Signature · 8 lines
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitorsQuoted 5 lines · Bernd Petrovitsch
Quoted 1 line · Mike Isely
The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
It seems to me that they aer somwhat similar, If I read
http://www.emacswiki.org/cgi-bin/wiki/IndentingC.
I had no idea about that wiki. Very nice. Thanks for pointing it out.
However I don't understand that comment. There is no reference to c-indent-tabs-mode anywhere on that page except in use in a single example - and I think that's a typo in the example. And c-indent-tabs-mode is unrecognized by my GNU emacs version 21 installation.
Quoted 11 lines
Quoted 3 lines
It's also not better or worse than c-basic-offset; it's complementary. The following all work together:
[ ... concise description deleted ...]
Quoted 3 lines
illustrate the relationship among those settings. So just "eliminating" c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish what one might expect.
Sorry, I never meant replacing but adding it to enforce the CodingStyle. And adding "tab-width: 8" is also not wrong (and *if* there is a correct default value for tab-width:, it is IMHO 8).
Then there is agreement here that the original proposed patch is not a good idea.
Quoted 10 lines
Quoted 3 lines
I think it's good form to have all those settings in a source file (with c-basic-offset set to 8 not four like the example above). It's not
/me too.
Quoted 4 lines
redundant with the documented style. It causes anyone who loads the file with emacs to automatically adopt the indentation conventions intended for that source file and that has to be a good thing.
Quoted 6 lines
Quoted 4 lines
I for one work in environments other than v4l-dvb, and those other environments don't always have the same coding style. To me it makes perfect sense that the coding style can be encoded into the source file itself. Then I don't have to worry about manually reconfiguring my
Yup. Actually vi/vim supports similar annotations.
I'm not a vi/vim expert, but I've had one coworker who was. Every time I committed a change with those emacs declarations added, he always followed up with another commit to add the vi/vim equivalents :-)
-Mike
Signature · 8 lines
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitorsAm Sonntag, den 25.03.2007, 18:28 -0500 schrieb Mike Isely:
Quoted 48 lines · Bernd Petrovitsch
Quoted 6 lines · Mike Isely
Quoted 1 line
The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
It seems to me that they aer somwhat similar, If I read
http://www.emacswiki.org/cgi-bin/wiki/IndentingC.I had no idea about that wiki. Very nice. Thanks for pointing it out.
However I don't understand that comment. There is no reference to c-indent-tabs-mode anywhere on that page except in use in a single example - and I think that's a typo in the example. And c-indent-tabs-mode is unrecognized by my GNU emacs version 21 installation.
Quoted 11 lines
Quoted 3 lines
It's also not better or worse than c-basic-offset; it's complementary. The following all work together:
[ ... concise description deleted ...]
Quoted 3 lines
illustrate the relationship among those settings. So just "eliminating" c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish what one might expect.
Sorry, I never meant replacing but adding it to enforce the CodingStyle. And adding "tab-width: 8" is also not wrong (and *if* there is a correct default value for tab-width:, it is IMHO 8).
Then there is agreement here that the original proposed patch is not a good idea.
Quoted 15 lines
Quoted 3 lines
I think it's good form to have all those settings in a source file (with c-basic-offset set to 8 not four like the example above). It's not
/me too.
Quoted 8 lines
redundant with the documented style. It causes anyone who loads the file with emacs to automatically adopt the indentation conventions intended for that source file and that has to be a good thing.
I for one work in environments other than v4l-dvb, and those other environments don't always have the same coding style. To me it makes perfect sense that the coding style can be encoded into the source file itself. Then I don't have to worry about manually reconfiguring my
Quoted 8 lines
Quoted 1 line
Yup. Actually vi/vim supports similar annotations.
I'm not a vi/vim expert, but I've had one coworker who was. Every time I committed a change with those emacs declarations added, he always followed up with another commit to add the vi/vim equivalents :-)
-Mike
Hi,
it is true that this all is not unimportant, but never made some new hardware/tuner work, it is all only clean up in delay.
If we depend on coding style to test something ... ,
we can close the shop.
Cheers,
Hermann
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors