Skip to contentSkip to conversation

Possible fix for 32-bit guests

RFT Avi Kivity 1 participant 1 message Mar 28, 2007 KVM

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw

Attached is a patch that fixes problems with 32-bit guests on 64-bit hosts. For example, I got damn small linux 0.4.10 to boot with this; previously it segfaulted during init.

If you have issues with 32-bit guests, please test with this patch and report. Even if you don't have any issues, testing your usual guests is appreciated.

Signature · 1 line
error compiling committee.c: too many arguments to function
drivers/kvm/x86_emulate.c +2 -4
index 7513cdd..daff430 100644
@@ -832,10 +832,8 @@ done_prefixes:
 		dst.type = OP_MEM;
 		dst.ptr = (unsigned long *)cr2;
 		dst.bytes = (d & ByteOp) ? 1 : op_bytes;
-		if (d & BitOp) {
-			dst.ptr += src.val / BITS_PER_LONG;
-			dst.bytes = sizeof(long);
-		}
+		if (d & BitOp)
+			dst.ptr += src.val / (dst.bytes * 8);
 		if (!(d & Mov) && /* optimisation - avoid slow emulated read */
 		    ((rc = ops->read_emulated((unsigned long)dst.ptr,
 					      &dst.val, dst.bytes, ctxt)) != 0))

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel