Skip to contentSkip to conversation

Xen netfront fixes for changed skbuff in net-2.6.22.git

DISCUSSION Jeremy Fitzhardinge 2 participants 4 messages Mar 28, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Herbert,

I wonder if you've got a chance to look at netfront in light of the new stuff in davem's network tree (the stuff that's in
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.22.git).

In particular, struct sk_buff has been changed so that "nh" has gone, and the replacement can be just an offset rather than a full pointer. This breaks the netfront because it tries to stash a page * in nh.raw. I had a quick look at it and couldn't see an easy fix, but I don't really understand what's going on in there.

But you do. Any chance you could have a look at it, and at least give me some pointers about how to proceed?

Thanks,
J

#1 lore raw

Hi Jeremy:

Quoted 4 lines · Jeremy Fitzhardinge

I wonder if you've got a chance to look at netfront in light of the new stuff in davem's network tree (the stuff that's in
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.22.git).

I've had a look at now and you can just stuff it into one of the other pointers that's still there. We just need to make sure that it is reset properly before we feed the packet into the stack. The pointer skb->dev is one candidate but there are plenty of others.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw
Quoted 5 lines · Herbert Xu

I've had a look at now and you can just stuff it into one of the other pointers that's still there. We just need to make sure that it is reset properly before we feed the packet into the stack. The pointer skb->dev is one candidate but there are plenty of others.

Hm, I was wondering if there's a nicer way of getting the same result. Does it need to be done that way?

Thanks,
J

#3 lore raw
Quoted 3 lines · Jeremy Fitzhardinge

Hm, I was wondering if there's a nicer way of getting the same result. Does it need to be done that way?

Actually you could use the skb->cb buffer which can store anything and doesn't need to be cleaned up.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt