Skip to contentSkip to conversation

Fix wrong assumption about irq and vector in msi_ia64.c

PATCH In review Ishimatsu Yasuaki 2 participants 2 messages Apr 6, 2007 – Apr 7, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix wrong assumption about irq and vector in msi_ia64.c

This patch fixes a wrong assumption in ia64 MSI code that IRQ equals vector.

---
 arch/ia64/kernel/msi_ia64.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.21-rc5/arch/ia64/kernel/msi_ia64.c
=================================--- linux-2.6.21-rc5.orig/arch/ia64/kernel/msi_ia64.c 2007-04-05 21:30:52.000000000 +0900
+++ linux-2.6.21-rc5/arch/ia64/kernel/msi_ia64.c 2007-04-05 21:31:34.000000000 +0900
@@ -76,7 +76,7 @@

        set_irq_msi(irq, desc);
        dest_phys_id = cpu_physical_id(first_cpu(cpu_online_map));

- vector = irq;
+ vector = irq_to_vector(irq);

        msg.address_hi = 0;
        msg.address_lo @@ -110,7 +110,7 @@

static int ia64_msi_retrigger_irq(unsigned int irq) {
- unsigned int vector = irq;

+       unsigned int vector = irq_to_vector(irq);
        ia64_resend_irq(vector);

        return 1;
#1 lore raw

Hey Yasu,

It seems that the tabs are replaced by the spaces accidentally, please fix it.

Satoru

At Fri, 06 Apr 2007 16:51:12 +0900,

Quoted 35 lines · Ishimatsu Yasuaki

This patch fixes a wrong assumption in ia64 MSI code that IRQ equals vector.

---
 arch/ia64/kernel/msi_ia64.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.21-rc5/arch/ia64/kernel/msi_ia64.c
=================================> --- linux-2.6.21-rc5.orig/arch/ia64/kernel/msi_ia64.c 2007-04-05 21:30:52.000000000 +0900
+++ linux-2.6.21-rc5/arch/ia64/kernel/msi_ia64.c 2007-04-05 21:31:34.000000000 +0900

(quoted diff) +1 -1
@@ -76,7 +76,7 @@
 
        set_irq_msi(irq, desc);
        dest_phys_id = cpu_physical_id(first_cpu(cpu_online_map));
-       vector = irq;
+       vector = irq_to_vector(irq);
 
        msg.address_hi = 0;
        msg.address_lo > @@ -110,7 +110,7 @@

static int ia64_msi_retrigger_irq(unsigned int irq) {

(quoted diff) +1 -2
-       unsigned int vector = irq;
+       unsigned int vector = irq_to_vector(irq);
        ia64_resend_irq(vector);
 
        return 1;
-

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html