Skip to contentSkip to conversation

the overdue removal of pci_module_init()

PATCH In review Adrian Bunk 2 participants 2 messages Apr 6, 2007 – Apr 14, 2007

Subsystems (2)
Documentation PCI
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 the overdue removal of pci_module_init()

Unless we finally completely remove it, people will always add new users.

Signed-off-by Adrian Bunk <[email protected]>

---

This patch obsoletes mark-pci_module_init-deprecated.patch in -mm.

 Documentation/feature-removal-schedule.txt |    7 -------
 Documentation/pci.txt                      |    2 --
 include/linux/pci.h                        |    6 ------
 3 files changed, 15 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -7
@@ -104,13 +104,6 @@
 
 ---------------------------
 
-What:	pci_module_init(driver)
-When:	January 2007
-Why:	Is replaced by pci_register_driver(pci_driver).
-Who:	Richard Knutsson <[email protected]> and Greg Kroah-Hartman <[email protected]>
-
----------------------------
-
 What:	Usage of invalid timevals in setitimer
 When:	March 2007
 Why:	POSIX requires to validate timevals in the setitimer call. This
Documentation/pci.txt renamed from Documentation/pci.txt.old +0 -2
@@ -545,8 +545,6 @@
 pci_set_power_state()		Set PCI Power Management state (0=D0 ... 3=D3)
 pci_find_capability()		Find specified capability in device's capability
 				list.
-pci_module_init()		Inline helper function for ensuring correct
-				pci_driver initialization and error handling.
 pci_resource_start()		Returns bus start address for a given PCI region
 pci_resource_end()		Returns bus end address for a given PCI region
 pci_resource_len()		Returns the byte length of a PCI region
include/linux/pci.h renamed from include/linux/pci.h.old +0 -6
@@ -410,12 +410,6 @@
 	.vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \
 	.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID
 
-/*
- * pci_module_init is obsolete, this stays here till we fix up all usages of it
- * in the tree.
- */
-#define pci_module_init	pci_register_driver
-
 /**
  * PCI_VDEVICE - macro used to describe a specific pci device in short form
  * @vend: the vendor name
#1 lore raw

Re: PCI: the overdue removal of pci_module_init()

Quoted 6 lines · Adrian Bunk

Unless we finally completely remove it, people will always add new users.

Signed-off-by Adrian Bunk <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>

If this is really it, then ACK!

Quoted 61 lines
---
 Documentation/feature-removal-schedule.txt |    7 -------
 Documentation/pci.txt                      |    2 --
 include/linux/pci.h                        |    6 ------
 3 files changed, 15 deletions(-)
Documentation/feature-removal-schedule.txt +0 -7
@@ -105,13 +105,6 @@ Who:   Adrian Bunk <[email protected]>
 
 ---------------------------
 
-What:	pci_module_init(driver)
-When:	January 2007
-Why:	Is replaced by pci_register_driver(pci_driver).
-Who:	Richard Knutsson <[email protected]> and Greg Kroah-Hartman <[email protected]>
-
----------------------------
-
 What:	Usage of invalid timevals in setitimer
 When:	March 2007
 Why:	POSIX requires to validate timevals in the setitimer call. This
Documentation/pci.txt +0 -2
@@ -545,8 +545,6 @@ pci_find_slot()			Find pci_dev correspon
 pci_set_power_state()		Set PCI Power Management state (0=D0 ... 3=D3)
 pci_find_capability()		Find specified capability in device's capability
 				list.
-pci_module_init()		Inline helper function for ensuring correct
-				pci_driver initialization and error handling.
 pci_resource_start()		Returns bus start address for a given PCI region
 pci_resource_end()		Returns bus end address for a given PCI region
 pci_resource_len()		Returns the byte length of a PCI region
include/linux/pci.h +0 -6
@@ -405,12 +405,6 @@ struct pci_driver {
 	.vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \
 	.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID
 
-/*
- * pci_module_init is obsolete, this stays here till we fix up all usages of it
- * in the tree.
- */
-#define pci_module_init	pci_register_driver
-
 /**
  * PCI_VDEVICE - macro used to describe a specific pci device in short form
  * @vend: the vendor name

Patches currently in gregkh-2.6 which might be from [email protected] are

bad/sysfs-crash-debugging.patch driver/the-overdue-removal-of-the-mount-umount-uevents.patch pci/pci-fix-multiple-definition-of-queue_pushbutton_work.patch pci/pci-remove-the-broken-pci_multithread_probe-option.patch pci/pci-define-pci_request-release_regions-for-config_pci-n.patch pci/pci-the-overdue-removal-of-pci_module_init.patch usb/usb-gtco.c-fix-a-use-before-check.patch usb/usb-iowarrior.c-fix-null-dereference.patch