Skip to contentSkip to conversation

Add first generation macbook subsystem ID

PATCH Applied [email protected] 2 participants 2 messages Apr 17, 2007 Sound

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 Add first generation macbook subsystem ID

From: Abhijit Bhopatkar <[email protected]>

First generation MacBooks were getting ignored by sigmatel drivers and wrongly being identified as MACMINI. This patch makes them identify as MACBOOK.

Signed-off-by Abhijit Bhopatkar <[email protected]>
---
 sound/pci/hda/patch_sigmatel.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +3 -0
index c94291b..cb99df5 100644
@@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec)
 		 */
 		printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id);
 		switch (codec->subsystem_id) {
+		case 0x106b0a00: /* MacBook First generatoin */
+			spec->board_config = STAC_MACBOOK;
+			break;
 		case 0x106b0200: /* MacBook Pro first generation */
 			spec->board_config = STAC_MACBOOK_PRO_V1;
 			break;
Signature · 1 line
1.4.4.2
Applied
#1 lore raw

At Tue, 17 Apr 2007 10:01:47 +0530,

Quoted 8 lines · [email protected] wrote:

From: Abhijit Bhopatkar <[email protected]>

First generation MacBooks were getting ignored by sigmatel drivers and wrongly being identified as MACMINI. This patch makes them identify as MACBOOK.

Signed-off-by Abhijit Bhopatkar <[email protected]>

This actually doesn't change behavior at all (both mac mini and mac book use the same pin configs), but it's still nice to add ID if any specific fix would be needed in future.

Applied to ALSA tree now. Thanks.

Takashi

Quoted 26 lines
---
 sound/pci/hda/patch_sigmatel.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +3 -0
index c94291b..cb99df5 100644
@@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec)
 		 */
 		printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id);
 		switch (codec->subsystem_id) {
+		case 0x106b0a00: /* MacBook First generatoin */
+			spec->board_config = STAC_MACBOOK;
+			break;
 		case 0x106b0200: /* MacBook Pro first generation */
 			spec->board_config = STAC_MACBOOK_PRO_V1;
 			break;
Signature · 6 lines
1.4.4.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel