crypto: Use padlock.ko only as a module

The padlock.ko module is completely useless when compiled in because it can't do anything and gets run too early to output anything useful:

[    6.052000] padlock: No VIA PadLock drivers have been loaded.
[    6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
[    6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.

Signed-off-by Simon Arlott <[email protected]>

Cc Herbert Xu <[email protected]>

---
 drivers/crypto/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

drivers/crypto/Makefile +0 -0

index 6059cf8..f0f7a73 100644

drivers/crypto/Makefile line 6

Quoted 11 lines · On Sat, 28 Apr 2007 17:44:42 +0100 Simon Arlott wrote:

The padlock.ko module is completely useless when compiled in because it can't do anything and gets run too early to output anything useful.

drivers/crypto/Makefile +3 -1

@@ -1,4 +1,6 @@
-obj-$(CONFIG_CRYPTO_DEV_PADLOCK) += padlock.o
+ifeq ($(CONFIG_CRYPTO_DEV_PADLOCK),m)
+obj-m += padlock.o
+endif
 obj-$(CONFIG_CRYPTO_DEV_PADLOCK_AES) += padlock-aes.o
 obj-$(CONFIG_CRYPTO_DEV_PADLOCK_SHA) += padlock-sha.o
 obj-$(CONFIG_CRYPTO_DEV_GEODE) += geode-aes.o

I think that we prefer to enforce config symbols in Kconfig files, not in Makefiles. E.g.,

---
 drivers/crypto/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/crypto/Kconfig +1 -1

@@ -2,7 +2,7 @@ menu "Hardware crypto devices"
 
 config CRYPTO_DEV_PADLOCK
 	tristate "Support for VIA PadLock ACE"
-	depends on X86_32
+	depends on X86_32 && m
 	select CRYPTO_ALGAPI
 	default m
 	help

Ideally I'd just remove that module completely, all it does is trigger the loading of the other two modules when modules are used - so I'll submit a patch for that instead.