Skip to contentSkip to conversation

Fix wrong identifier name in Documentation/driver-model/devres.txt

DOC New Rolf Eike Beer 4 participants 6 messages Apr 26, 2007 – May 1, 2007 Documentation

lore
Share & tools
lore

Rolf Eike Beer

author
#0 lore raw

Above and below we talk about my_midlayer_create_something, I assume that is also meant here.

Signed-off-by Rolf Eike Beer <[email protected]>

---
commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
tree cd948e03b4add89be6e648d31b7778c64a51e8d2
parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
author Rolf Eike Beer <[email protected]> Thu, 26 Apr 2007 09:23:39 +0200 committer Rolf Eike Beer <[email protected]> Thu, 26 Apr 2007 09:23:39 +0200

 Documentation/driver-model/devres.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/driver-model/devres.txt +1 -1
index 5163b85..6c8d8f2 100644
@@ -182,7 +182,7 @@ For example, you can do something like the following.
 
 	...
 
-	devres_close_group(dev, my_midlayer_something);
+	devres_close_group(dev, my_midlayer_create_something);
 	return 0;
   }
#2 lore raw
In reply to Rolf Eike Beer
Quoted 20 lines · Rolf Eike Beer

Above and below we talk about my_midlayer_create_something, I assume that is also meant here.

Signed-off-by Rolf Eike Beer <[email protected]>

---
commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
tree cd948e03b4add89be6e648d31b7778c64a51e8d2
parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
author Rolf Eike Beer <[email protected]> Thu, 26 Apr 2007 09:23:39 +0200 committer Rolf Eike Beer <[email protected]> Thu, 26 Apr 2007 09:23:39 +0200

 Documentation/driver-model/devres.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/driver-model/devres.txt +0 -0
index 5163b85..6c8d8f2 100644

Documentation/driver-model/devres.txt For example, you can do something like the following. · line 186

Quoted 6 lines
Documentation/driver-model/devres.txt +1 -1
@@ -182,7 +182,7 @@ For example, you can do something like the following.
 
...
 
-	devres_close_group(dev, my_midlayer_something);
+	devres_close_group(dev, my_midlayer_create_something);
 	return 0;

hmmm.

Now that devres is in the kernel, I don't think I am the best person to merge these sort of patches. Certainly I can, and I know the code from my original review and subsequent usage, but I think the patch is more appropriate for Greg, going through normal maintainership channels.

IOW, I think devres is too generic to be queued via libata-dev.git.

Tejun, comments?

Jeff

#3 lore raw
Quoted 8 lines · Jeff Garzik

Now that devres is in the kernel, I don't think I am the best person to merge these sort of patches. Certainly I can, and I know the code from my original review and subsequent usage, but I think the patch is more appropriate for Greg, going through normal maintainership channels.

IOW, I think devres is too generic to be queued via libata-dev.git.

Tejun, comments?

I don't have problem either way. If it's okay with Greg, I'll queue future devres updates through Greg.

BTW, converting network drivers to devres is on my ever-growing todo list and when those are done they will go through you, Jeff. :-)

Signature · 1 line
tejun
#4 lore raw
Quoted 6 lines · Tejun Heo
Quoted 5 lines · Jeff Garzik

Now that devres is in the kernel, I don't think I am the best person to merge these sort of patches. Certainly I can, and I know the code from my original review and subsequent usage, but I think the patch is more appropriate for Greg, going through normal maintainership channels.

Quoted 6 lines
Quoted 3 lines

IOW, I think devres is too generic to be queued via libata-dev.git.

Tejun, comments?

I don't have problem either way. If it's okay with Greg, I'll queue future devres updates through Greg.

It's fine with me, send them on :)

thanks,

greg k-h

#5 lore raw

PATCH 1/1 DOC: Fix wrong identifier name in Documentation/driver-model/devres.txt

From: Rolf Eike Beer <[email protected]>

Above and below we talk about my_midlayer_create_something, I assume that is also meant here.

Signed-off-by Rolf Eike Beer <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
Documentation/driver-model/devres.txt +1 -1
index 5163b85..6c8d8f2 100644
@@ -182,7 +182,7 @@ For example, you can do something like t
 
 	...
 
-	devres_close_group(dev, my_midlayer_something);
+	devres_close_group(dev, my_midlayer_create_something);
 	return 0;
   }