CIFS: make sec=none force an anonymous mount
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Jeff Layton
We had a customer report that attempting to make CIFS mount with a null username (i.e. doing an anonymous mount) doesn't work. Looking through the code, it looks like CIFS expects a NULL username from userspace in order to trigger an anonymous mount. The mount.cifs code doesn't seem to ever pass a null username to the kernel, however.
Yes - cifs kernel code expects a NULL username (e.g. "username=") if you really don't want to pass the default username of the uid of the current process and you don't set the username explicitly (e.g. in a credential file or mount parameter).
Samba userspace tools (and smbfs) handled this by first trying to
setup the SMB session using the default user, and if that fails with access denied then retrying sessionsetup with a null username string. This would be easy to change in mount.cifs (ie as long as username was not explicitly passed on mount then if mount fails with access denied simply add a retry with "username="). This was
discussed at SambaXP.
Quoted 4 lines · Christoph Hellwig
Looks useful. In case you have some spare time at your hand it would be really nice to convert cifs option parsing to the
lib/parser.ccode and move all validation of the arguments into one place, so it's easily understanable and better to maintain.
Yes - that would be excellent. The parse_mount_options badly needs to
be rewritten now that the number of mount options needed has grown. This is something Alex Bokovoy and I discussed last week at SambaXP for both the kernel code and the user space mount.cifs code.
Alex had volunteered to rewrite the user space cifs mount option parsing code (and also change to use the safer talloc library)
Quoted 11 lines · Steve French (smfltc)
Quoted 5 lines · Jeff Layton
We had a customer report that attempting to make CIFS mount with a null username (i.e. doing an anonymous mount) doesn't work. Looking through the code, it looks like CIFS expects a NULL username from userspace in order to trigger an anonymous mount. The mount.cifs code doesn't seem to ever pass a null username to the kernel, however.
Yes - cifs kernel code expects a NULL username (e.g. "username=") if you really don't want to pass the default username of the uid of the current process and you don't set the username explicitly (e.g. in a credential file or mount parameter).
Quoted 8 lines
Samba userspace tools (and smbfs) handled this by first trying to setup the SMB session using the default user, and if that fails with access denied then retrying sessionsetup with a null username string. This would be easy to change in mount.cifs (ie as long as username was not explicitly passed on mount then if mount fails with access denied simply add a retry with "username="). This was discussed at SambaXP.
Does this mean you're NAK'ing this patch in favor of a userspace fix? My perspective is that if someone explicitly requests sec=none, then we ought to do an anonymous mount regardless of how the username is set. Would you agree that that behavior is what you would want?
Quoted 7 lines
Quoted 4 lines · Christoph Hellwig
Looks useful. In case you have some spare time at your hand it would be really nice to convert cifs option parsing to the
lib/parser.ccode and move all validation of the arguments into one place, so it's easily understanable and better to maintain.
Quoted 7 lines
Yes - that would be excellent. The
parse_mount_optionsbadly needs to be rewritten now that the number of mount options needed has grown. This is something Alex Bokovoy and I discussed last week at SambaXP for both the kernel code and the user space mount.cifs code. Alex had volunteered to rewrite the user space cifs mount option parsing code (and also change to use the safer talloc library)
Definitely, though that sounds like a big project and I don't have the time to tackle it at the moment :-)
Thanks,
Jeff
Quoted 24 lines · Jeff Layton
Quoted 10 lines · Steve French (smfltc)
Quoted 7 lines · Jeff Layton
We had a customer report that attempting to make CIFS mount with a null username (i.e. doing an anonymous mount) doesn't work. Looking through the code, it looks like CIFS expects a NULL username from userspace in order to trigger an anonymous mount. The mount.cifs code doesn't seem to ever pass a null username to the kernel, however.
Quoted 10 lines
Yes - cifs kernel code expects a NULL username (e.g. "username=") if you really don't want to pass the default username of the uid of the current process and you don't set the username explicitly (e.g. in a credential file or mount parameter).
Samba userspace tools (and smbfs) handled this by first trying to
setup the SMB session using the default user, and if that fails with access denied then retrying sessionsetup with a null username string. This would be easy to change in mount.cifs (ie as long as username was not explicitly passed on mount then if mount fails with access denied simply add a retry with "username="). This was
discussed at SambaXP.
Quoted 8 lines
Does this mean you're NAK'ing this patch in favor of a userspace fix? My perspective is that if someone explicitly requests sec=none, then we ought to do an anonymous mount regardless of how the username is set. Would you agree that that behavior is what you would want?
Your patch is probably ok to add, although I would like to see if any of the other Samba team had thoughts on this, as "null user" sessions are a fairly obscure part of the protocol. But even with the kernel change, mount.cifs also should change for a loosely related case that of
1) sec=none is not specified by the user
2) but username also is not specified explicitly
For that case we need to retry on access denied as if it were a request for a "null user" mount ie send sec=none (or equivalently username=) the 2nd time. This gets more complicated since mount.cifs also has to retry on a couple of other cases (e.g. when the server does not support port 445 but does not take the standard server string "*SMBSERVER" on the RFC1001 called name).
If there are no objections from any of the other Samba guys I will take your patch which has the effect of treating "sec=none" as meaning "ingore any userid if specified, and set the username to null
on the session setup"). That is consistent with what we documented.
I had though for a while that a user who mounts passing both "sec=none" and a username might also expect to get a null password (they could have done this with "guest" or with "password=") or might want to try to send the password in plaintext - but I doubt that we want to support a user who wants to send the password plaintext without the server requiring it (and in that case cifs can be built and configured to allow plaintext if absolutely necessary to support those ancient servers).
Basically if we set username to null in kernel when (sec=none)
Quoted 5 lines
Thanks,
Jeff
A message that is not in the archive (sent off-list or not yet received): OFEFD715DD.89A7A57F-ON872572D2.003A0BCE-862572D2.003AC6CA@us.ibm.com
Quoted 5 lines · Shirish S Pargaonkar
When a session setup request is sent as an anonymous user (NUL user), should/could there be
password associated with that?
Right now, sec=none option, will prompt you for a password.
We should probably turn off password prompting if sec=none is specified.
Quoted 8 lines
And when we add code to retry session setup as anonymous user if the first session setup request
fails, should that retry request be sent with the password or without password?When smbfs sends requests as an anonymous user, it does not send a password along with it.
I'd say we'd want to avoid sending along the password in any situation where it wasn't really needed.
-- Jeff
Quoted 8 lines · Shirish S Pargaonkar
When a session setup request is sent as an anonymous user (NUL user), should/could there be password associated with that?
Right now, sec=none option, will prompt you for a password.
And when we add code to retry session setup as anonymous user if the first session setup request fails, should that retry request be sent with the password or without password?
Quoted 6 lines
When smbfs sends requests as an anonymous user, it does not send a password along with it.
Regards,
Shirish
We should allow a password to be specified (presumably it is not common for a server to have a password associated with a null user), but probably not prompt (similar to "guest" - except for the case of guest, we start with the username of uid of current process, and only if it fails with access denied do we try "user=" (or equivalently sec=none))