Skip to contentSkip to conversation

vt8623fb: New framebuffer driver for VIA VT8623

PATCH In review Antonino A. Daplas 5 participants 13 messages May 5, 2007 – May 8, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 6/20 vt8623fb: New framebuffer driver for VIA VT8623

From: Ondrej Zajicek <[email protected]>

This patch adds fbdev driver for graphics core in VIA VT8623

---

 Documentation/fb/vt8623fb.txt |   64 +++
 drivers/video/Kconfig         |   14 +
 drivers/video/Makefile        |    1 
 drivers/video/vt8623fb.c      |  920 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 999 insertions(+), 0 deletions(-)
Documentation/fb/vt8623fb.txt new file +64 -0
new file mode 100644
index 0000000..f654576
@@ -0,0 +1,64 @@
+
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================
+
+
+Supported Hardware
+==================
+
+	VIA VT8623 [CLE266] chipset and	its graphics core
+		(known as CastleRock or Unichrome)
+
+I tested vt8623fb on VIA EPIA ML-6000
+
+
+Supported Features
+==================
+
+	*  4 bpp pseudocolor modes (with 18bit palette, two variants)
+	*  8 bpp pseudocolor mode (with 18bit palette)
+	* 16 bpp truecolor mode (RGB 565)
+	* 32 bpp truecolor mode (RGB 888)
+	* text mode (activated by bpp = 0)
+	* doublescan mode variant (not available in text mode)
+	* panning in both directions
+	* suspend/resume support
+	* DPMS support
+
+Text mode is supported even in higher resolutions, but there is limitation to
+lower pixclocks (maximum about 100 MHz). This limitation is not enforced by
+driver. Text mode supports 8bit wide fonts only (hardware limitation) and
+16bit tall fonts (driver limitation).
+
+There are two 4 bpp modes. First mode (selected if nonstd == 0) is mode with
+packed pixels, high nibble first. Second mode (selected if nonstd == 1) is mode
+with interleaved planes (1 byte interleave), MSB first. Both modes support
+8bit wide fonts only (driver limitation).
+
+Suspend/resume works on systems that initialize video card during resume and
+if device is active (for example used by fbcon).
+
+
+Missing Features
+================
+(alias TODO list)
+
+	* secondary (not initialized by BIOS) device support
+	* MMIO support
+	* interlaced mode variant
+	* support for fontwidths != 8 in 4 bpp modes
+	* support for fontheight != 16 in text mode
+	* hardware cursor
+	* video overlay support
+	* vsync synchronization
+	* acceleration support (8514-like 2D, busmaster transfers)
+
+
+Known bugs
+==========
+
+	* cursor disable in text mode doesn't work
+
+
+--
+Ondrej Zajicek <[email protected]>
drivers/video/Kconfig +14 -0
index c0dc955..c3b26a4 100644
@@ -1345,6 +1345,20 @@ config FB_VOODOO1
 	  Please read the <file:Documentation/fb/README-sstfb.txt> for supported
 	  options and other important info  support.
 
+config FB_VT8623
+	tristate "VIA VT8623 support"
+	depends on FB && PCI
+	select FB_CFB_FILLRECT
+	select FB_CFB_COPYAREA
+	select FB_CFB_IMAGEBLIT
+	select FB_TILEBLITTING
+	select FB_SVGALIB
+	select VGASTATE
+	select FONT_8x16 if FRAMEBUFFER_CONSOLE
+	---help---
+	  Driver for CastleRock integrated graphics core in the
+	  VIA VT8623 [Apollo CLE266] chipset.
+
 config FB_CYBLA
 	tristate "Cyberblade/i1 support"
 	depends on FB && PCI && X86_32 && !64BIT
drivers/video/Makefile +1 -0
index 12a573b..2caaee3 100644
@@ -54,6 +54,7 @@ obj-$(CONFIG_FB_VALKYRIE)         += val
 obj-$(CONFIG_FB_CT65550)          += chipsfb.o
 obj-$(CONFIG_FB_IMSTT)            += imsttfb.o
 obj-$(CONFIG_FB_FM2)              += fm2fb.o
+obj-$(CONFIG_FB_VT8623)           += vt8623fb.o
 obj-$(CONFIG_FB_CYBLA)            += cyblafb.o
 obj-$(CONFIG_FB_TRIDENT)          += tridentfb.o
 obj-$(CONFIG_FB_LE80578)          += vermilion/
drivers/video/vt8623fb.c new file +920 -0

920 lines not on this page · raw message

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#1 lore raw
Quoted 20 lines · Antonino A. Daplas

From: Ondrej Zajicek <[email protected]>

This patch adds fbdev driver for graphics core in VIA VT8623

---

 Documentation/fb/vt8623fb.txt |   64 +++
 drivers/video/Kconfig         |   14 +
 drivers/video/Makefile        |    1 
 drivers/video/vt8623fb.c      |  920 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 999 insertions(+), 0 deletions(-)
Documentation/fb/vt8623fb.txt new file +0 -0
new file mode 100644
index 0000000..f654576

Documentation/fb/vt8623fb.txt line 3

Quoted 3 lines
Documentation/fb/vt8623fb.txt new file +3 -0
@@ -0,0 +1,64 @@
+
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Signature · 9 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
#2 lore raw
Quoted 4 lines · Ville Syrjälä

Documentation/fb/vt8623fb.txt line 3

Quoted 2 lines
Documentation/fb/vt8623fb.txt new file +2 -0
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Yes, this hardware is supported by several out-of-tree drivers, some of them are named viafb.

Signature · 5 lines
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: [email protected], jabber: [email protected])
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
Linux-fbdev-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

#3 lore raw
Quoted 8 lines · Ondrej Zajicek
Quoted 4 lines · Ville Syrjälä

Documentation/fb/vt8623fb.txt line 3

Quoted 2 lines
Documentation/fb/vt8623fb.txt new file +2 -0
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Yes, this hardware is supported by several out-of-tree drivers, some of them are named viafb.

The "official" (ie. the one from via) was just posted here for inclusion.

Signature · 9 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
#4 lore raw
Quoted 11 lines · Ville Syrjälä
Quoted 8 lines · Ondrej Zajicek
Quoted 4 lines · Ville Syrjälä

Documentation/fb/vt8623fb.txt line 3

Quoted 2 lines
Documentation/fb/vt8623fb.txt new file +2 -0
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Yes, this hardware is supported by several out-of-tree drivers, some of them are named viafb.

The "official" (ie. the one from via) was just posted here for inclusion.

You mean that tiny one which talks about GUEUEs and such?

Who plans on cleaning that one up? Who is prepared to see VIA just plough on regardless after that, just like VIA did with the X driver?

Luc Verhaegen.
http://unichrome.sf.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#5 lore raw
Quoted 8 lines · Luc Verhaegen
Quoted 7 lines · Ville Syrj채l채
Quoted 6 lines · Ondrej Zajicek
Quoted 4 lines · Ville Syrj채l채

Documentation/fb/vt8623fb.txt line 3

Quoted 2 lines
Documentation/fb/vt8623fb.txt new file +2 -0
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Yes, this hardware is supported by several out-of-tree drivers, some of them are named viafb.

The "official" (ie. the one from via) was just posted here for inclusion.

You mean that tiny one which talks about GUEUEs and such?

I hope you're being ironic with the 'tiny' :-), because the patch that came from VIA was humongous.

Quoted 4 lines

Who plans on cleaning that one up? Who is prepared to see VIA just plough on regardless after that, just like VIA did with the X driver?

Yep, just looking at that patch, it will be a difficult one to clean up.

Tony

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Linux-fbdev-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

#6 lore raw
Quoted 7 lines · Antonino A. Daplas
Quoted 2 lines · Luc Verhaegen

You mean that tiny one which talks about GUEUEs and such?

I hope you're being ironic with the 'tiny' :-), because the patch that came from VIA was humongous.

Well, my estimate for a full featured fb driver for this hardware would be around 10kloc/300kB source.

Quoted 8 lines
Quoted 4 lines

Who plans on cleaning that one up? Who is prepared to see VIA just plough on regardless after that, just like VIA did with the X driver?

Yep, just looking at that patch, it will be a difficult one to clean up.

Tony

It takes a special kind of idiot to take something like that on and keep it up too.

Luc Verhaegen.
http://unichrome.sf.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#7 lore raw
Quoted 8 lines · Luc Verhaegen
Quoted 4 lines · Antonino A. Daplas

Yep, just looking at that patch, it will be a difficult one to clean up.

Tony

It takes a special kind of idiot to take something like that on and keep it up too.

So you're better off with the rudimentary driver, at least that can be fixed on reasonable terms.

Luc Verhaegen.
http://unichrome.sf.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#8 lore raw
Quoted 5 lines · Luc Verhaegen
Quoted 4 lines · Luc Verhaegen
Quoted 3 lines · Antonino A. Daplas

Yep, just looking at that patch, it will be a difficult one to clean up.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Tony

It takes a special kind of idiot to take something like that on and keep it up too.

So you're better off with the rudimentary driver, at least that can be fixed on reasonable terms.

It would be nice to have a clean driver with enough features so people don't have to hunt around in a maze of different driver versions to get the features they need. It's a shame people have just forked the driver several times without really trying to work on a common codebase and get it included in the kernel.

I think a big portion of the blame falls on VIA since they are the original authors and the they have decided not to work with the community. Maybe that's changing now that they posted the patches (even though they aren't clean). I didn't really read the viafb patch thread so I missed the details. Are they are prepared to clean it up or do they just expect to dump the code here and forget about it?

Signature · 9 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
#9 lore raw
Quoted 7 lines · Ville Syrjälä

I think a big portion of the blame falls on VIA since they are the original authors and the they have decided not to work with the community. Maybe that's changing now that they posted the patches (even though they aren't clean). I didn't really read the viafb patch thread so I missed the details. Are they are prepared to clean it up or do they just expect to dump the code here and forget about it?

I of course don't know anything what i say here for sure, but i'd be really surprised if VIA did change their act.

VIA has a history of either:
* freeing code, seeing it cleaned up and included in the relevant project, yet continuing a seperate fork in VIA-space nonetheless (X driver).
* purposefully forking projects to keep VIA specific adaptations in (xine, mplayer)

I don't see why this here would be any different.

If VIAs own driver does get reworked by fb/kernel people and included, then VIA will not accept these changes and will just continue things seperately themselves.

The fact that some backward compatibility defines were deemed superfluous already, and the fact that VIAs direct customers probably want those things to be possible for quite some time still, will mean that VIA will see no other option but to keep things in their own fork.

History repeating.

Luc Verhaegen.
http://unichrome.sf.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#10 lore raw
In reply to Ville Syrjälä
Quoted 11 lines · Ville Syrj채l채
Quoted 8 lines · Ondrej Zajicek
Quoted 4 lines · Ville Syrj채l채

Documentation/fb/vt8623fb.txt line 3

Quoted 2 lines
Documentation/fb/vt8623fb.txt new file +2 -0
+	vt8623fb - fbdev driver for graphics core in VIA VT8623 chipset
+	===============================================================

Doesn't viafb support this hardware?

Yes, this hardware is supported by several out-of-tree drivers, some of them are named viafb.

The "official" (ie. the one from via) was just posted here for inclusion.

The patch from VIA, at its present state, is not fit for inclusion. We either wait for that (indefinitely) or include this and then merge later on.

Tony

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Linux-fbdev-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

#11 lore raw
In reply to Antonino A. Daplas
Quoted 1 line · On Sat, 05 May 2007 22:49:14 +0800 "Antonino A. Daplas" <[email protected]>…

This patch adds fbdev driver for graphics core in VIA VT8623

Is bust with CONFIG_MTRR=n

drivers/video/vt8623fb.c: In function `vt8623_pci_remove':
drivers/video/vt8623fb.c:797: error: `par' undeclared (first use in this function) drivers/video/vt8623fb.c:797: error: (Each undeclared identifier is reported only once drivers/video/vt8623fb.c:797: error: for each function it appears in.)

(that's ia64)

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

#12 lore raw

PATCH 1/1 vt8623fb: Fix compile error if CONFIG_MTRR=n

Fix compile error if CONFIG_MTRR=n

---

Quoted 4 lines · Andrew Morton
Quoted 1 line · On Sat, 05 May 2007 22:49:14 +0800 "Antonino A. Daplas" <[email protected]>…

This patch adds fbdev driver for graphics core in VIA VT8623

Quoted 8 lines

Is bust with CONFIG_MTRR=n

drivers/video/vt8623fb.c: In function `vt8623_pci_remove':
drivers/video/vt8623fb.c:797: error: `par' undeclared (first use in this function) drivers/video/vt8623fb.c:797: error: (Each undeclared identifier is reported only once drivers/video/vt8623fb.c:797: error: for each function it appears in.)

(that's ia64)

 drivers/video/vt8623fb.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/video/vt8623fb.c +1 -3
index 414e76b..5e9755e 100644
@@ -778,12 +778,10 @@ err_enable_device:
 static void __devexit vt8623_pci_remove(struct pci_dev *dev)
 {
 	struct fb_info *info = pci_get_drvdata(dev);
+	struct vt8623fb_info *par = info->par;
 
 	if (info) {
-
 #ifdef CONFIG_MTRR
-		struct vt8623fb_info *par = info->par;
-
 		if (par->mtrr_reg >= 0) {
 			mtrr_del(par->mtrr_reg, 0, 0);
 			par->mtrr_reg = -1;

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/