Skip to contentSkip to conversation

pm2fb: Fix of jumps in pm2fb_probe

PATCH New Krzysztof Helt 1 participant 1 message May 4, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pm2fb: Fix of jumps in pm2fb_probe

From: Krzysztof Helt <[email protected]>

This patch fixes incorrect targets of jumps when an error occurs in the pm2fb_probe.

Signed-off-by <[email protected]>

---

This patch may requires pm2fb patches I sent before.

--- linux-2.6.21.orig/drivers/video/pm2fb.c 2007-05-03 14:46:
06.000000000 +0200
+++ linux-2.6.21/drivers/video/pm2fb.c 2007-05-03 14:46:59.
000000000 +0200
@@ -1210,10 +1209,10 @@ static int __devinit pm2fb_probe(struct
info->var = pm2fb_var;

if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
- goto err_exit_all;
+ goto err_exit_both;

if (register_framebuffer(info) < 0)
- goto err_exit_both;
+ goto err_exit_all;

printk(KERN_INFO "fb%d: %s frame buffer device, memory = %
dK.\n",
info->node, info->fix.id, pm2fb_fix.smem_len / 1024);

----------------------------------------------------
Zobacz, jaką walkę stoczy superbohater, by ocalić siebie i swych bliskich. A największa bitwa rozegra się w jego duszy. SPIDER-MAN 3 w kinach od 4 maja.
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fspiderman3.html&sid=1122

drivers/video/pm2fb.c +2 -2
@@ -1210,10 +1209,10 @@ static int __devinit pm2fb_probe(struct 
 		info->var = pm2fb_var;
 
 	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
-		goto err_exit_all;
+		goto err_exit_both;
 
 	if (register_framebuffer(info) < 0)
-		goto err_exit_both;
+		goto err_exit_all;
 
 	printk(KERN_INFO "fb%d: %s frame buffer device, memory = %dK.\n",
 	       info->node, info->fix.id, pm2fb_fix.smem_len / 1024);

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
Linux-fbdev-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel