Skip to contentSkip to conversation

DM9000: fix use of kfree() on net device

PATCH Applied Ben Dooks 2 participants 2 messages May 7, 2007 – May 8, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 DM9000: fix use of kfree() on net device

The DM9000 network driver is calling kfree() on an netdev causing the system to oops if the probe fails. The right thing to do is call free_netdev().

Thanks to Russell King for spotting this.

Signed-off-by Ben Dooks <[email protected]>
drivers/net/dm9000.c +2 -2
diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c linux-2.6.20-dmfix/drivers/net/dm9000.c
@@ -601,7 +601,7 @@ dm9000_probe(struct platform_device *pde
 	printk("%s: not found (%d).\n", CARDNAME, ret);
 
 	dm9000_release_board(pdev, db);
-	kfree(ndev);
+	free_netdev(ndev);
 
 	return ret;
 }

@@ -1194,7 +1194,7 @@ dm9000_drv_remove(struct platform_device
 
 	unregister_netdev(ndev);
 	dm9000_release_board(pdev, (board_info_t *) ndev->priv);
-	kfree(ndev);		/* free device structure */
+	free_netdev(ndev);		/* free device structure */
 
 	PRINTK1("clean_module() exit\n");

-
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#1 lore raw
Quoted 7 lines · Ben Dooks

The DM9000 network driver is calling kfree() on an netdev causing the system to oops if the probe fails. The right thing to do is call free_netdev().

Thanks to Russell King for spotting this.

Signed-off-by Ben Dooks <[email protected]>

applied