Skip to contentSkip to conversation

Makefile cleanup part2

PATCH New Fabio Massimo Di Nitto 2 participants 2 messages May 15, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile cleanup part2

Hi guys,

this patch restore the make dependencies within the same subproject (same as it was before the big rework), do some PHONY clean up, clean up a few Makefiles that were still using an old format.

Please commit or ack and I will apply.

I also noticed the following unused files:

gfs/gfs_edit/ondisk.c
gfs2/edit/ondisk.c

Can I kill them?

Thanks
Fabio

Signature · 5 lines
I'm going to make him an offer he can't refuse.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: foo.diff
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070515/2e22626d/attachment.ksh>
#1 lore raw

PATCH 1/1 Makefile cleanup part2

Quoted 11 lines · Fabio Massimo Di Nitto

Hi guys,

this patch restore the make dependencies within the same subproject (same as it was before the big rework), do some PHONY clean up, clean up a few Makefiles that were still using an old format.

Please commit or ack and I will apply.

I also noticed the following unused files:

Quoted 7 lines

gfs/gfs_edit/ondisk.c
gfs2/edit/ondisk.c

Can I kill them?

Thanks
Fabio

Hi Fabio,

I didn't test it, but I did review 90% of it and it looked good, so ACK. Yes, you can kill those ondisk.c files. I should have done that; my bad.

Regards,

Bob Peterson
Red Hat Cluster Suite