Skip to contentSkip to conversation

spidernet: skb used after netif_receive_skb

PATCH New Florin Malita 1 participant 1 message May 17, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spidernet: skb used after netif_receive_skb

The stats update code in spider_net_pass_skb_up() is touching the skb after it's been passed up to the stack. To avoid that, just update the stats first.

---

spider_net.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/spider_net.c +0 -0
index 108adbf..1df2f0b 100644
@@ -1013,12 +1013,12 @@ spider_net_pass_skb_up(struct spider_net_descr *descr,
		 */
	}

- /* pass skb up to stack */
- netif_receive_skb(skb);
-

	/* update netdevice statistics */
	card->netdev_stats.rx_packets++;
	card->netdev_stats.rx_bytes += skb->len;

+
+ /* pass skb up to stack */
+ netif_receive_skb(skb);
}

#ifdef DEBUG