Skip to contentSkip to conversation

ARM: OMAP: Fix warning in dsp_ctl_core.c

PATCH In review Dirk Behme 2 participants 2 messages May 18, 2007

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Fix warning in dsp_ctl_core.c

Fix warning

arch/arm/plat-omap/dsp/dsp_ctl_core.c: In function 'dsp_ctl_core_open':
arch/arm/plat-omap/dsp/dsp_ctl_core.c:46: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result

Signed-off-by Dirk Behme <[email protected]>
arch/arm/plat-omap/dsp/dsp_ctl_core.c +2 -1
Index: linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
===================================================================
@@ -43,7 +43,8 @@ static int dsp_ctl_core_open(struct inod
 	static DEFINE_MUTEX(open_lock);
 	int ret = 0;
 
-	mutex_lock_interruptible(&open_lock);
+	if (mutex_lock_interruptible(&open_lock))
+		return -EINTR;
 	if (omap_dsp->initialized == 0) {
 		ret = dsp_late_init();
 		if (ret != 0) {
#1 lore raw
Quoted 16 lines · Dirk Behme

Fix warning

arch/arm/plat-omap/dsp/dsp_ctl_core.c: In function 'dsp_ctl_core_open':
arch/arm/plat-omap/dsp/dsp_ctl_core.c:46: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result

Signed-off-by Dirk Behme <[email protected]>

Index: linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
===================================================================

arch/arm/plat-omap/dsp/dsp_ctl_core.c static int dsp_ctl_core_open(struct inod · line 50

Quoted 9 lines
arch/arm/plat-omap/dsp/dsp_ctl_core.c +2 -1
@@ -43,7 +43,8 @@ static int dsp_ctl_core_open(struct inod
 	static DEFINE_MUTEX(open_lock);
 	int ret = 0;
 
-	mutex_lock_interruptible(&open_lock);
+	if (mutex_lock_interruptible(&open_lock))
+		return -EINTR;
 	if (omap_dsp->initialized == 0) {
 		ret = dsp_late_init();
 		if (ret != 0) {

Pushing today.

Tony