Skip to contentSkip to conversation

removes mismatch section warnigs in sparc time.c file

PATCH In review Krzysztof Helt 2 participants 3 messages May 19, 2007 – May 20, 2007 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 removes mismatch section warnigs in sparc time.c file

From: Krzysztof Helt <[email protected]>

This patch removes mismatch section warnings in the sparc/kernel/time.c file.

---
The patch diff-ed agains 2.6.22-rc2

arch/sparc/kernel/time.c +2 -2
diff -urp linux-2.6.21/arch/sparc/kernel/time.c linux-2.6.21.new/arch/sparc/kernel/time.c
@@ -148,7 +148,7 @@ irqreturn_t timer_interrupt(int irq, voi
 }
 
 /* Kick start a stopped clock (procedure from the Sun NVRAM/hostid FAQ). */
-static void __init kick_start_clock(void)
+static void __devinit kick_start_clock(void)
 {
 	struct mostek48t02 *regs = (struct mostek48t02 *)mstk48t02_regs;
 	unsigned char sec;
@@ -223,7 +223,7 @@ static __inline__ int has_low_battery(vo
 	return (data1 == data2);	/* Was the write blocked? */
 }
 
-static void __init mostek_set_system_time(void)
+static void __devinit mostek_set_system_time(void)
 {
 	unsigned int year, mon, day, hour, min, sec;
 	struct mostek48t02 *mregs;
maintainer
#1 lore raw

From: Krzysztof Helt <[email protected]>
Date: Sun, 20 May 2007 19:11:25 +0200

Quoted 6 lines

From: Krzysztof Helt <[email protected]>

This patch removes mismatch section warnings in the sparc/kernel/time.c file.

Why in the world do you have CONFIG HOTPLUG enabled on sparc32? That's the only way I see that you could trigger this warning. No hotplugging is possible with any device type at all on that platform :-)

But of course the patch is correct so I'll apply this, thank you.

#2 lore raw
In reply to Krzysztof Helt
Quoted 5 lines · David Miller

Why in the world do you have CONFIG HOTPLUG enabled on sparc32? That's the only way I see that you could trigger this warning. No hotplugging is possible with any device type at all on that platform :-)

I have checked. The CONFIG_HOTPLUG is y by default and is selectable (visible option) only if CONFIG_EMBEDDED is set.

Simply, I cannot disable it with menuconfig so I never thought about it.

Regards,
Krzysztof