Skip to contentSkip to conversation

new libata-code breaks functionality of sata_sis

PATCH Uwe Koziolek 2 participants 2 messages May 22, 2007 – May 23, 2007 libata

lore
Share & tools
lore
#0 lore raw

a SiS180 controller is connected with a PATA-disk. Starting with 2.6.22-rc1 the disk is no longer working.

sata_sis 0000:01:07.0: version 0.7
ACPI: PCI Interrupt Link [APC4] enabled at IRQ 19
ACPI: PCI Interrupt 0000:01:07.0[A] -> Link [APC4] -> GSI 19 (level, low) -> IRQ 16
sata_sis 0000:01:07.0: Detected SiS 180/181 chipset in combined mode scsi0 : sata_sis
scsi1 : sata_sis
ata1: PATA max UDMA/133 cmd 0x00019000 ctl 0x00019402 bmdma 0x0001a000 irq 0
ata2: PATA max UDMA/133 cmd 0x00019800 ctl 0x00019c02 bmdma 0x0001a008 irq 0
ata1: port disabled. ignoring.
ata2: port disabled. ignoring.
ATA: abnormal status 0x7F on port 0x00019807

ata2 must be a SATA port.
this problem can be solved by the patch.

ata1 must not be disabled
For this problem i have no solution.

drivers/ata/sata_sis.c 2007-05-23 00:24:28.000000000 +0200 renamed from drivers/ata/sata_sis.c 2007-05-22 11:05:38.000000000 +0200 +1 -1
@@ -255,7 +255,7 @@
 {
        static int printed_version;
        struct ata_port_info pi = sis_port_info;
-       const struct ata_port_info *ppi[] = { &pi, NULL };
+       const struct ata_port_info *ppi[] = { &pi, &pi };
        struct ata_host *host;
        u32 genctl, val;
        u8 pmr;
#1 lore raw

Thanks for fixing this. Can you post with proper subject line and Signed-off-by?

Signature · 1 line
tejun