Skip to contentSkip to conversation

Add select PHYLIB to the UCC_GETH Kconfig option

PATCH In review Jan Altenberg 4 participants 4 messages May 23, 2007 – May 25, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jan Altenberg

author
#0 lore raw

PATCH 1/1 Add select PHYLIB to the UCC_GETH Kconfig option

ucc_geth has been migrated to use the common phylib code. So lets add a 'select PHYLIB' to the UCC_GETH Kconfig entry.

Signed-off-by Jan Altenberg <[email protected]>
---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
Index: linux-2.6/drivers/net/Kconfig
===================================================================
@@ -2280,6 +2280,7 @@ config GFAR_NAPI
 config UCC_GETH
 	tristate "Freescale QE Gigabit Ethernet"
 	depends on QUICC_ENGINE
+	select PHYLIB
 	select UCC_FAST
 	help
 	  This driver supports the Gigabit Ethernet mode of the QUICC Engine,
#2 lore raw
In reply to Jan Altenberg
Quoted 14 lines · Jan Altenberg

ucc_geth has been migrated to use the common phylib code. So lets add a 'select PHYLIB' to the UCC_GETH Kconfig entry.

Signed-off-by Jan Altenberg <[email protected]>
---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/drivers/net/Kconfig
===================================================================

drivers/net/Kconfig config GFAR_NAPI · line 2284

Quoted 5 lines
drivers/net/Kconfig +1 -0
@@ -2280,6 +2280,7 @@ config GFAR_NAPI
 config UCC_GETH
 	tristate "Freescale QE Gigabit Ethernet"
 	depends on QUICC_ENGINE
+	select PHYLIB
 	select UCC_FAST

Please fix the Kconfig warnings first.

Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?

I am tired of five independent people patching the same driver.

Jeff

#3 lore raw
Quoted 2 lines

-----Original Message-----
From: [email protected]

[mailto:[email protected]] On

Quoted 4 lines

Behalf Of Jeff Garzik
Sent: Friday, May 25, 2007 5:48 AM
To: Jan Altenberg
Cc: Phillips Kim-R1AAHA; [email protected];

[email protected]

Quoted 4 lines

Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

Quoted 1 line · Jan Altenberg

ucc_geth has been migrated to use the common phylib code. So lets

add a

Quoted 8 lines
Quoted 8 lines

'select PHYLIB' to the UCC_GETH Kconfig entry.

Signed-off-by Jan Altenberg <[email protected]>
---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines

drivers/net/Kconfig config GFAR_NAPI · line 2284

Quoted 10 lines

Index: linux-2.6/drivers/net/Kconfig
===================================================================

drivers/net/Kconfig +1 -0
@@ -2280,6 +2280,7 @@ config GFAR_NAPI
 config UCC_GETH
 	tristate "Freescale QE Gigabit Ethernet"
 	depends on QUICC_ENGINE
+	select PHYLIB
 	select UCC_FAST

Please fix the Kconfig warnings first.

I will follow up this.

Quoted 3 lines

Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?

I am tired of five independent people patching the same driver.

Sorry for the trouble, I will post a patch to the MAINTAINER file and help to maintain ucc_geth related patches.

- Leo