Skip to contentSkip to conversation

hwmon-vid: Don't spam the logs when VRM

PATCH In review Jean Delvare 2 participants 2 messages May 25, 2007 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon-vid: Don't spam the logs when VRM

If we cannot guess which VRM version the CPU uses, we set it to 0 and log it. So we shouldn't spam the log each time vid_from_reg() is later called with vrm 0.

---
Rudolf, is it OK with you? Please ack or nack.

 drivers/hwmon/hwmon-vid.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hwmon/hwmon-vid.c +3 -1
@@ -132,7 +132,9 @@ int vid_from_reg(int val, u8 vrm)
 		val &= 0x7f;
 		return(val > 0x77 ? 0 : (1500000 - (val * 12500) + 500) / 1000);
 	default:		/* report 0 for unknown */
-		printk(KERN_INFO "hwmon-vid: requested unknown VRM version\n");
+		if (vrm)
+			printk(KERN_WARNING "hwmon-vid: requested unknown "
+			       "VRM version (%u)\n", (unsigned int)vrm);
 		return 0;
 	}
 }
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors