Skip to contentSkip to conversation

missing return

PATCH In review Jerald Fitzjerald 2 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 missing return

OK for mainline?

---

base85.c +0 -0
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
		 */
		if (0x03030303 < acc ||
		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
		acc += de;
		say1(" %08x", acc);
#1 lore raw
Quoted 1 line · Jerald Fitzjerald

OK for mainline?

Sure, with a signoff please.

I realize that I've seen this pointed out by somebody already. Thanks for reminder.

#2 lore raw
Quoted 2 lines · Junio C Hamano

I realize that I've seen this pointed out by somebody already.

It was suggested on irc a couple of days ago.

---

base85.c +0 -0
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
		 */
		if (0x03030303 < acc ||
		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
		acc += de;
		say1(" %08x", acc);