update doc for hns3
cover update doc for hns3
Here series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes.
Lijun Ou (2):
doc: update release notes for hns3
doc: fix hns3 rst
Min Hu (Connor) (1):
doc: add FEC in NIC features
doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 + doc/guides/nics/hns3.rst | 2 +- doc/guides/rel_notes/release_21_02.rst | 4 ++++ 4 files changed, 20 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
PATCH 1/3 doc: add FEC in NIC features
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
--- doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 + 2 files changed, 15 insertions(+)
doc/guides/nics/features.rst +14 -0
@@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. +.. _nic_features_fec: + +FEC +--- + +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode. +It adds error correction information to data packets at the transmit end, and uses the error correction +information to correct the bit errors generated during data packet transmission at the receive end. This +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required. + +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``. +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. +* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. + .. _nic_features_other: Other dev ops not represented by a Feature
doc/guides/nics/features/default.ini +1 -0
@@ -65,6 +65,7 @@ Module EEPROM dump = Registers dump = LED = Multiprocess aware = +FEC = BSD nic_uio = Linux UIO = Linux VFIO =
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
Quoted 26 lines · Lijun Ou
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
Signed-off-by Min Hu (Connor) <[email protected]>Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 + 2 files changed, 15 insertions(+)doc/guides/nics/features.rst +4
-0@@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. +.. _nic_features_fec: + +FEC +---
doc/guides/nics/features.rst Supports to get Rx/Tx packet burst mode information. · line 942
Quoted 10 lines
doc/guides/nics/features.rst +10
-0+ +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode. +It adds error correction information to data packets at the transmit end, and uses the error correction +information to correct the bit errors generated during data packet transmission at the receive end. This +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required. + +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``. +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. +* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. +
Feature doc looks good, thanks for adding this.
Can you add another patch in this series to update .ini files for hns3 & cxgbe to advertise FEC feature?
Quoted 9 lines
doc/guides/nics/features.rst +0
-0.. _nic_features_other: Other dev ops not represented by a Featuredoc/guides/nics/features/default.ini +0
-0
doc/guides/nics/features/default.ini Module EEPROM dump = · line 71
Quoted 7 lines
doc/guides/nics/features/default.ini +1
-0@@ -65,6 +65,7 @@ Module EEPROM dump = Registers dump = LED = Multiprocess aware = +FEC = BSD nic_uio = Linux UIO = Linux VFIO =
"Linux UIO" etc renamed in this release, can you rebase on top of latest repo please?
Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
Quoted 37 lines · Ferruh Yigit
Quoted 36 lines · Lijun Ou
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
Signed-off-by Min Hu (Connor) <[email protected]>Signed-off-by Lijun Ou <[email protected]>---
doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 +2 files changed, 15 insertions(+)doc/guides/nics/features.rst +6
-0@@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. +.. _nic_features_fec: + +FEC +--- + +Supports Forward error correction. Forward error correction (FEC) is a biterror correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.doc/guides/nics/features.rst +2
-0+ +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``,
Quoted 9 lines
Quoted 6 lines
``fec_set``.
+* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+Feature doc looks good, thanks for adding this.
cc'ed Andrew too for comment.
Quoted 19 lines
Can you add another patch in this series to update .ini files for hns3 & cxgbe to advertise FEC feature?
Quoted 7 lines
..
_nic_features_other:
Other dev ops not represented by a Featuredoc/guides/nics/features/default.ini +0
-0@@ -65,6 +65,7 @@ Module EEPROM dump =Quoted 8 lines
Registers dump =
LED =
Multiprocess aware =
+FEC =
BSD nic_uio =
Linux UIO =
Linux VFIO ="Linux UIO" etc renamed in this release, can you rebase on top of latest repo please?
Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
In reply to Ferruh YigitQuoted 48 lines · Ferruh Yigit
Quoted 38 lines · Lijun Ou
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
Signed-off-by Min Hu (Connor) <[email protected]>Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 + 2 files changed, 15 insertions(+)doc/guides/nics/features.rst +0
-0@@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``,``tx_burst_mode_get``.
* **[related] API**: ``rte_eth_rx_burst_mode_get()``,
``rte_eth_tx_burst_mode_get()``.
+.._nic_features_fec:doc/guides/nics/features.rst +5
-0+ +FEC +--- + +Supports Forward error correction. Forward error correction (FEC) isa bit error correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.doc/guides/nics/features.rst +2
-0+ +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``,Quoted 6 lines
``fec_set``.
+* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``,
``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related] API**: ``rte_eth_fec_get_capability()``,
``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+Feature doc looks good, thanks for adding this.
Quoted 2 lines
Can you add another patch in this series to update .ini files for hns3 & cxgbe to advertise FEC feature?
ok. I will do it in next version.
Quoted 19 lines
Quoted 8 lines
..
_nic_features_other:
Other dev ops not represented by a Featuredoc/guides/nics/features/default.ini +0
-0doc/guides/nics/features/default.ini Module EEPROM dump = · line 71
Quoted 7 lines
doc/guides/nics/features/default.ini +1
-0@@ -65,6 +65,7 @@ Module EEPROM dump = Registers dump = LED = Multiprocess aware = +FEC = BSD nic_uio = Linux UIO = Linux VFIO ="Linux UIO" etc renamed in this release, can you rebase on top of latest repo please? .
Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
28/01/2021 02:55, oulijun:
Quoted 22 lines
Quoted 22 lines
Quoted 13 lines
doc/guides/nics/features.rst +4
-0+FEC +--- + +Supports Forward error correction. Forward error correction (FEC) isa bit error correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.(quoted diff) +2
-0+ +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``,Quoted 6 lines
``fec_set``.
+* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``,
``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related] API**: ``rte_eth_fec_get_capability()``,
``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+Feature doc looks good, thanks for adding this.
Quoted 4 lines
Quoted 3 lines
Can you add another patch in this series to update .ini files for hns3 & cxgbe to advertise FEC feature?
ok. I will do it in next version.
I suppose updating drivers can be done in the same patch.
PATCH 2/3 doc: update release notes for hns3
In reply to Lijun OuAdd TM(Traffic Management) feature with hns3 in release notes.
--- doc/guides/rel_notes/release_21_02.rst | 4 ++++ 1 file changed, 4 insertions(+)
doc/guides/rel_notes/release_21_02.rst +4 -0
@@ -82,6 +82,10 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF + * **Updated Intel ice driver.** * Added Double VLAN support for DCF switch QinQ filtering.
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3
Quoted 2 lines · Lijun Ou
Add TM(Traffic Management) feature with hns3 in release notes.
Can you please add the commits of the patches introducing the feature mentioned in the release notes as fixes tag, for reference?
Quoted 10 lines
Signed-off-by Lijun Ou <[email protected]>--- doc/guides/rel_notes/release_21_02.rst | 4 ++++ 1 file changed, 4 insertions(+)doc/guides/rel_notes/release_21_02.rst +0
-0
doc/guides/rel_notes/release_21_02.rst New Features · line 88
Quoted 7 lines
doc/guides/rel_notes/release_21_02.rst +4
-0@@ -82,6 +82,10 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF +
This is giving doc build warning [1], I guess an empty line required after first line, also should there be two bullet points?
doc build can be tested as:
meson setup -Denable_docs=true build-doc
ninja -C build-doc
[1]
release_21_02.rst:87: WARNING: Unexpected indentation
Quoted 4 lines
doc/guides/rel_notes/release_21_02.rst +0
-0* **Updated Intel ice driver.** * Added Double VLAN support for DCF switch QinQ filtering.
PATCH 3/3 doc: fix hns3 rst
In reply to Lijun OuHere fixes the Kunpeng introduction address link with hns3.rst
--- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/hns3.rst +1 -1
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are: Prerequisites ------------- - Get the information about Kunpeng920 chip using - `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_. + `<https://www.hisilicon.com/en/products/Kunpeng>`_. - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
Signature · 1 line
2.7.4
v2 cover update doc for hns3
In reply to Lijun OuHere series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes.
v2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.
Lijun Ou (4):
net/hns3: add FEC feature for hns3.ini
net/cxgbe: add FEC feature for cxgbe.ini
doc: update release notes for hns3
doc: fix hns3 rst
Min Hu (Connor) (1):
doc: add FEC in NIC features
doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/hns3.ini | 1 + doc/guides/nics/hns3.rst | 2 +- doc/guides/rel_notes/release_21_02.rst | 5 +++++ 6 files changed, 23 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
PATCH v2 1/5 doc: add FEC in NIC features
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
---V1->V2:
- Add Fixes for indicating that the driver is updated synchronously.
--- doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/default.ini | 1 + 2 files changed, 15 insertions(+)
doc/guides/nics/features.rst +14 -0
@@ -908,6 +908,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. +.. _nic_features_fec: + +FEC +--- + +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode. +It adds error correction information to data packets at the transmit end, and uses the error correction +information to correct the bit errors generated during data packet transmission at the receive end. This +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required. + +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``. +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. +* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. + .. _nic_features_other: Other dev ops not represented by a Feature
doc/guides/nics/features/default.ini +1 -0
@@ -65,6 +65,7 @@ Module EEPROM dump = Registers dump = LED = Multiprocess aware = +FEC = FreeBSD = Linux = Windows =
Signature · 1 line
2.7.4
PATCH v2 2/5 net/hns3: add FEC feature for hns3.ini
In reply to Lijun OuThe hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
--- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+)
doc/guides/nics/features/hns3.ini +1 -0
@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = Y Linux = Y ARMv8 = Y
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
28/01/2021 13:43, Lijun Ou:
Quoted 16 lines
The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
Fixes 9bf2ea8dbc65 ("net/hns3: support FEC")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+)doc/guides/nics/features/hns3.ini +0
-0
doc/guides/nics/features/hns3.ini Stats per queue = Y · line 42
Quoted 4 lines
doc/guides/nics/features/hns3.ini +1
-0@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = Y
Please don't use tabs but only spaces in such .ini file.
Can it be squashed with the commit adding the feature in default.ini?
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
Quoted 12 lines · Thomas Monjalon
28/01/2021 13:43, Lijun Ou:
Quoted 11 lines
The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
Fixes 9bf2ea8dbc65 ("net/hns3: support FEC")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
doc/guides/nics/features/hns3.ini Stats per queue = Y · line 42
Quoted 9 lines
doc/guides/nics/features/hns3.ini +1
-0@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = YPlease don't use tabs but only spaces in such .ini file.
OK, I will fix it
Quoted 1 line
Can it be squashed with the commit adding the feature in default.ini?
Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
Quoted 5 lines
.
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
Quoted 27 lines · oulijun
Quoted 12 lines · Thomas Monjalon
28/01/2021 13:43, Lijun Ou:
Quoted 11 lines
The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
Fixes 9bf2ea8dbc65 ("net/hns3: support FEC")Signed-off-by Lijun Ou <[email protected]>---
doc/guides/nics/features/hns3.ini | 1 +1 file changed, 1 insertion(+)Quoted 12 lines
Quoted 9 lines
doc/guides/nics/features/hns3.ini +0
-0@@ -39,5 +39,6 @@ Stats per queue = YFW version = Y
Registers dump = Y
Multiprocess aware = Y
+FEC = YPlease don't use tabs but only spaces in such .ini file.
Quoted 4 lines
OK, I will fix it
Quoted 1 line
Can it be squashed with the commit adding the feature in default.ini?
Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
29/01/2021 09:46, Ferruh Yigit:
Quoted 27 lines · oulijun
Quoted 26 lines · Thomas Monjalon
Quoted 25 lines
28/01/2021 13:43, Lijun Ou:
Quoted 17 lines
The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
Fixes 9bf2ea8dbc65 ("net/hns3: support FEC")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+)doc/guides/nics/features/hns3.ini +0
-0doc/guides/nics/features/hns3.ini Stats per queue = Y · line 42
Quoted 4 lines
doc/guides/nics/features/hns3.ini +1
-0@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = YPlease don't use tabs but only spaces in such .ini file.
Quoted 5 lines
Quoted 3 lines
OK, I will fix it
Quoted 1 line
Can it be squashed with the commit adding the feature in default.ini?
Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.
Yes please. All three patches have the same intent: add FEC to features doc.
Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
In reply to Ferruh YigitQuoted 28 lines · Ferruh Yigit
Quoted 27 lines · oulijun
Quoted 24 lines · Thomas Monjalon
28/01/2021 13:43, Lijun Ou:
Quoted 16 lines
The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting.
Fixes 9bf2ea8dbc65 ("net/hns3: support FEC")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+)doc/guides/nics/features/hns3.ini +0
-0doc/guides/nics/features/hns3.ini Stats per queue = Y · line 42
Quoted 4 lines
doc/guides/nics/features/hns3.ini +1
-0@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = YPlease don't use tabs but only spaces in such .ini file.
Quoted 7 lines
Quoted 4 lines
OK, I will fix it
Quoted 1 line
Can it be squashed with the commit adding the feature in default.ini?
Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged. .
Thanks. I will do it in next version
Quoted 1 line
PATCH v2 3/5 net/cxgbe: add FEC feature for cxgbe.ini
In reply to Lijun OuThe cxgbe PMD add FEC features implementation in 20.11. Therefore, need to update the cxgbe.ini for supporting.
--- doc/guides/nics/features/cxgbe.ini | 1 + 1 file changed, 1 insertion(+)
doc/guides/nics/features/cxgbe.ini +1 -0
@@ -28,6 +28,7 @@ Stats per queue = Y EEPROM dump = Y Registers dump = Y Multiprocess aware = Y +FEC = Y FreeBSD = Y Linux = Y x86-32 = Y
Signature · 1 line
2.7.4
PATCH v2 4/5 doc: update release notes for hns3
In reply to Lijun OuAdd TM(Traffic Management) feature with hns3 in release notes. It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PF
--- doc/guides/rel_notes/release_21_02.rst | 5 +++++ 1 file changed, 5 insertions(+)
doc/guides/rel_notes/release_21_02.rst +5 -0
@@ -82,6 +82,11 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF + * **Updated Intel ice driver.** Updated the Intel ice driver with new features and improvements, including:
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3
Quoted 18 lines · Lijun Ou
Add TM(Traffic Management) feature with hns3 in release notes. It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PFFixes c09c7847d892 ("net/hns3: support traffic management")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/rel_notes/release_21_02.rst | 5 +++++ 1 file changed, 5 insertions(+)doc/guides/rel_notes/release_21_02.rst +0
-0
doc/guides/rel_notes/release_21_02.rst New Features · line 89
Quoted 8 lines
doc/guides/rel_notes/release_21_02.rst +5
-0@@ -82,6 +82,11 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF +
Hi Lijun,
Are these two different items, or second sentences is continuation of the first one?
Quoted 4 lines
doc/guides/rel_notes/release_21_02.rst +0
-0* **Updated Intel ice driver.** Updated the Intel ice driver with new features and improvements, including:
Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3
Quoted 28 lines · Ferruh Yigit
Quoted 18 lines · Lijun Ou
Add TM(Traffic Management) feature with hns3 in release notes. It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PFFixes c09c7847d892 ("net/hns3: support traffic management")Signed-off-by Lijun Ou <[email protected]>--- doc/guides/rel_notes/release_21_02.rst | 5 +++++ 1 file changed, 5 insertions(+)doc/guides/rel_notes/release_21_02.rst +0
-0doc/guides/rel_notes/release_21_02.rst New Features · line 87
Quoted 6 lines
doc/guides/rel_notes/release_21_02.rst +5
-0@@ -82,6 +82,11 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF +Hi Lijun,
Quoted 1 line
Are these two different items, or second sentences is continuation of the first one?
Both the port peak rate and TC peak rate can be configured, or they can be configured separately.
Quoted 8 lines
Quoted 5 lines
doc/guides/rel_notes/release_21_02.rst +0
-0* **Updated Intel ice driver.** Updated the Intel ice driver with new features and improvements,including:
.
Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3
Quoted 31 lines · oulijun
Quoted 28 lines · Ferruh Yigit
Quoted 18 lines · Lijun Ou
Add TM(Traffic Management) feature with hns3 in release notes. It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PFFixes c09c7847d892 ("net/hns3: support traffic management")Signed-off-by Lijun Ou <[email protected]>---
doc/guides/rel_notes/release_21_02.rst| 5 +++++1 file changed, 5 insertions(+)doc/guides/rel_notes/release_21_02.rst +0
-0doc/guides/rel_notes/release_21_02.rst New Features · line 87
Quoted 6 lines
doc/guides/rel_notes/release_21_02.rst +5
-0@@ -82,6 +82,11 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + + * Added support for traffic management + Support for configuring port's peak rate and TC's peak rate with PF +Hi Lijun,
Quoted 2 lines
Quoted 1 line
Are these two different items, or second sentences is continuation of the first one?
Both the port peak rate and TC peak rate can be configured, or they can be configured separately.
I asked from formatting perspective. In the output html these two lines looks like a long single line, if the intention is to have them as they are seen in the .rst file additional formatting is required.
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
doc/guides/rel_notes/release_21_02.rst +0
-0* **Updated Intel ice driver.**Updated the Intel ice driver with new features and improvements, including:
.
PATCH v2 5/5 doc: fix hns3 rst
In reply to Lijun OuHere fixes the Kunpeng introduction address link with hns3.rst
--- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/hns3.rst +1 -1
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are: Prerequisites ------------- - Get the information about Kunpeng920 chip using - `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_. + `<https://www.hisilicon.com/en/products/Kunpeng>`_. - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
Signature · 1 line
2.7.4
v3 cover update doc for hns3
In reply to Lijun OuHere series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes.
v3:
1. merge patch[2/3] into patch[1] base on v2
2. fix some format errors
v2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.
Lijun Ou (2):
doc: update release notes for hns3
doc: fix hns3 rst
Min Hu (Connor) (1):
doc: add FEC in NIC features
doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/hns3.ini | 1 + doc/guides/nics/hns3.rst | 2 +- doc/guides/rel_notes/release_21_02.rst | 4 ++++ 6 files changed, 22 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
PATCH v3 1/3 doc: add FEC in NIC features
From: "Min Hu (Connor)" <[email protected]>
Document FEC in NIC features, add information about FEC and add implementation related support.
---V2->V3:
- merge patch 2 and patch 3 into patch 1 according to Thomas Monjalon's advice.
- fix format errors in hns3.ini and cxgbe.ini
V1->V2:
- add Fixes for indicating that the driver is updated synchronously.
--- doc/guides/nics/features.rst | 14 ++++++++++++++ doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/hns3.ini | 1 + 4 files changed, 17 insertions(+)
doc/guides/nics/features.rst +14 -0
@@ -908,6 +908,20 @@ Supports to get Rx/Tx packet burst mode information. * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. +.. _nic_features_fec: + +FEC +--- + +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode. +It adds error correction information to data packets at the transmit end, and uses the error correction +information to correct the bit errors generated during data packet transmission at the receive end. This +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required. + +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``. +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. +* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. + .. _nic_features_other: Other dev ops not represented by a Feature
doc/guides/nics/features/cxgbe.ini +1 -0
@@ -28,6 +28,7 @@ Stats per queue = Y EEPROM dump = Y Registers dump = Y Multiprocess aware = Y +FEC = Y FreeBSD = Y Linux = Y x86-32 = Y
doc/guides/nics/features/default.ini +1 -0
@@ -65,6 +65,7 @@ Module EEPROM dump = Registers dump = LED = Multiprocess aware = +FEC = FreeBSD = Linux = Windows =
doc/guides/nics/features/hns3.ini +1 -0
@@ -39,5 +39,6 @@ Stats per queue = Y FW version = Y Registers dump = Y Multiprocess aware = Y +FEC = Y Linux = Y ARMv8 = Y
Signature · 1 line
2.7.4
PATCH v3 2/3 doc: update release notes for hns3
In reply to Lijun OuAdd TM(Traffic Management) feature with hns3 in release notes. It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PF
---V2->V3:
- delete the unnecessary information lines
--- doc/guides/rel_notes/release_21_02.rst | 4 ++++ 1 file changed, 4 insertions(+)
doc/guides/rel_notes/release_21_02.rst +4 -0
@@ -82,6 +82,10 @@ New Features * Added support for 64B completion queue entries +* **Updated hns3 driver.** + + * Added support for traffic management + * **Updated Intel ice driver.** Updated the Intel ice driver with new features and improvements, including:
Signature · 1 line
2.7.4
PATCH v3 3/3 doc: fix hns3 rst
In reply to Lijun OuHere fixes the Kunpeng introduction address link with hns3.rst
--- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/hns3.rst +1 -1
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are: Prerequisites ------------- - Get the information about Kunpeng920 chip using - `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_. + `<https://www.hisilicon.com/en/products/Kunpeng>`_. - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
Signature · 1 line
2.7.4
Quoted 12 lines · Lijun Ou
Here series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes.
v3:
1. merge patch[2/3] into patch[1] base on v2
2. fix some format errorsv2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.
Quoted 7 lines
Lijun Ou (2):
doc: update release notes for hns3
doc: fix hns3 rstMin Hu (Connor) (1):
doc: add FEC in NIC features
For series,
Quoted 17 lines · Ferruh Yigit
Quoted 16 lines · Lijun Ou
Here series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes.
v3:
1. merge patch[2/3] into patch[1] base on v2
2. fix some format errorsv2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.Lijun Ou (2):
doc: update release notes for hns3
doc: fix hns3 rst
Quoted 6 lines
Quoted 3 lines
Min Hu (Connor) (1):
doc: add FEC in NIC featuresFor series,
Reviewed-by Ferruh Yigit <[email protected]>
Series applied to dpdk-next-net/main, thanks.