Skip to contentSkip to conversation

lost brelse in ext3_read_inode

PATCH New Vasily Averin 1 participant 1 message Jun 2, 2007 ext4 file system

lore
Share & tools
lore

Vasily Averin

author
#0 lore raw

PATCH 1/1 lost brelse in ext3_read_inode

From: Kirill Korotaev <[email protected]>

One of error path in ext3_read_inode() leaks bh since brelse is forgoten.

Signed-off-by Kirill Korotaev <[email protected]>
Acked-by Vasily Averin <[email protected]>
fs/ext3/inode.c +3 -1
index a6cb617..2a85dde 100644
@@ -2677,8 +2677,10 @@ void ext3_read_inode(struct inode * inode)
 		 */
 		ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
 		if (EXT3_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
-		    EXT3_INODE_SIZE(inode->i_sb))
+		    EXT3_INODE_SIZE(inode->i_sb)) {
+			brelse (bh);
 			goto bad_inode;
+		}
 		if (ei->i_extra_isize == 0) {
 			/* The extra space is currently unused. Use it. */
 			ei->i_extra_isize = sizeof(struct ext3_inode) -
fs/ext4/inode.c +3 -1
index b34182b..0cd7bc4 100644
@@ -2673,8 +2673,10 @@ void ext4_read_inode(struct inode * inode)
 		 */
 		ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
 		if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
-		    EXT4_INODE_SIZE(inode->i_sb))
+		    EXT4_INODE_SIZE(inode->i_sb)) {
+			brelse (bh);
 			goto bad_inode;
+		}
 		if (ei->i_extra_isize == 0) {
 			/* The extra space is currently unused. Use it. */
 			ei->i_extra_isize = sizeof(struct ext4_inode) -