Skip to contentSkip to conversation

Patch fixes bug for clearing the bss section

U-Boot-Users mushtaq khan 2 participants 5 messages Apr 30, 2007 – Jun 5, 2007

lore
Share & tools
lore
#0 lore raw

Hi,
There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S)
In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.

This patch fixes this bug by putting bss_start into %edi register. -------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bss_clear.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070430/77637fd9/attachment.txt

#1 lore raw
Quoted 9 lines · In message <[email protected]> you wrote:

Hi,
There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S)
In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.

This patch fixes this bug by putting bss_start into %edi register.

Applied to u-boot-testing.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would seem that evil retreats when forcibly confronted
	-- Yarnek of Excalbia, "The Savage Curtain", stardate 5906.5
#2 lore raw

Hi Wolfgang Denk,

Any issues with my Patches, SATA and clearing of bss section.
Please update me.

Thanks,
-Mushtaq

Quoted 24 lines · Wolfgang Denk
Quoted 10 lines · In message <[email protected]> you wrote:

Hi,
There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S)
In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.

This patch fixes this bug by putting bss_start into %edi register.

Applied to u-boot-testing.

Thanks.

Best regards,

Wolfgang Denk

#3 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

Any issues with my Patches, SATA and clearing of bss section.
Please update me.

Quoted 1 line · I wrote:
Quoted 1 line

Applied to u-boot-testing.

Did you test the code in the u-boot-testing repository? I did not receive any feedback from you (nor any form others).

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see but you do not observe.
Sir Arthur Conan Doyle, in "The Memoirs of Sherlock Holmes"
#4 lore raw

Hi Wolfgang Denk,

I tested my patches in u-boot-testing
1. Clearing of bss section patch and
2. Sata patch.

Clearing of bss section patch has no issues.
But with sata patch, got compilation warning: fuinction proto-type mismatch between block_read and sata_read.

This is becuase i had been working on u-boot downloaded on feb-15th. And on Apr-13th, patch "Fix use of "void *" for block dev read/write buffer pointers" has been applied, which has changed the proto-type of block_read function.

I will bring these changes to my patch. And after testing , i will re-submit the patch.

Thanks,
-Mushtaq Khan.

Quoted 25 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

Any issues with my Patches, SATA and clearing of bss section.
Please update me.

Quoted 3 lines · I wrote:
Quoted 3 lines

Applied to u-boot-testing.

Did you test the code in the u-boot-testing repository? I did not receive any feedback from you (nor any form others).

Best regards,

Wolfgang Denk