Skip to contentSkip to conversation

review: xfs_growfs_data_private() not logging agf length change

PATCH Tim Shimmin 3 participants 4 messages Jun 7, 2007 XFS filesystem

lore
Share & tools
lore

Tim Shimmin

author
#0 lore raw

Looks like we forgot to log the agf_length change here.

(cut 'n' pasted patch)

--Tim

===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================

fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000 renamed from fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000 +1 -0
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
        be32_add(&agf->agf_length, new);
        ASSERT(be32_to_cpu(agf->agf_length) ==
               be32_to_cpu(agi->agi_length));
+        xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
        /*
         * Free the new space.
         */
xfs/xfs_fsops.c renamed from agf_length.patch/fs/xfs/xfs_fsops.c +1 -0
@@ -332,6 +332,7 @@ xfs_growfs_data_private(
 		be32_add(&agf->agf_length, new);
 		ASSERT(be32_to_cpu(agf->agf_length) ==
 		       be32_to_cpu(agi->agi_length));
+		xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
 		/*
 		 * Free the new space.
 		 */
#1 lore raw
Quoted 13 lines · Tim Shimmin

Looks like we forgot to log the agf_length change here.

(cut 'n' pasted patch)

--Tim

===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================

fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000 xfs_growfs_data_private( · line 334

Quoted 7 lines
fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000 renamed from fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000 +1 -0
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
        be32_add(&agf->agf_length, new);
        ASSERT(be32_to_cpu(agf->agf_length) ==
               be32_to_cpu(agi->agi_length));
+        xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
        /*
         * Free the new space.
         */

Yup, looks ok to me.

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
#2 lore raw
Quoted 11 lines · David Chinner
Quoted 10 lines · Tim Shimmin

Looks like we forgot to log the agf_length change here.

(cut 'n' pasted patch)

--Tim

===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================

Quoted 12 lines

fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000 xfs_growfs_data_private( · line 334

Quoted 10 lines
fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000 renamed from fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000 +1 -0
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
        be32_add(&agf->agf_length, new);
        ASSERT(be32_to_cpu(agf->agf_length) ==
               be32_to_cpu(agi->agi_length));
+        xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
        /*
         * Free the new space.
         */

Yup, looks ok to me.

Except for the whitespace damage, of course - but that might have been the cut & pasting.

#3 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 6 lines · David Chinner
Quoted 5 lines · Tim Shimmin

Looks like we forgot to log the agf_length change here.

(cut 'n' pasted patch)

--Tim

.....

Quoted 5 lines
Quoted 2 lines

Yup, looks ok to me.

Except for the whitespace damage, of course - but that might have been the cut & pasting.

The attached patch had no ws damage. ;)

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group