Skip to contentSkip to conversation

Move omap_timer to the initdata section.

PATCH In review Vivien Chappelier 2 participants 2 messages Jun 9, 2007 – Jun 12, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 12/12 Move omap_timer to the initdata section.

This patch fixes a warning due to omap_timer not belonging to the __initdata section as it should.

---
arch/arm/mach-omap1/time.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap1/time.c +0 -0
index 3705d20..0ba739c 100644
@@ -289,6 +289,6 @@ static void __init omap_timer_init(void)
    omap_init_clocksource(rate);

}

-struct sys_timer omap_timer = {
+struct sys_timer omap_timer __initdata = {
.init = omap_timer_init,
};

Signature · 1 line
1.5.1.3
reviewer
#1 lore raw
Quoted 15 lines · Vivien Chappelier

This patch fixes a warning due to omap_timer not belonging to the __initdata
section as it should.

---
arch/arm/mach-omap1/time.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap1/time.c +0 -0
index 3705d20..0ba739c 100644

arch/arm/mach-omap1/time.c static void __init omap_timer_init(void) · line 293

Quoted 6 lines
arch/arm/mach-omap1/time.c +1 -1
@@ -289,6 +289,6 @@ static void __init omap_timer_init(void)
    omap_init_clocksource(rate);
 }
-struct sys_timer omap_timer = {
+struct sys_timer omap_timer __initdata = {
    .init        = omap_timer_init,
 };

We cannot drop sys_timer, it's needed. There have been posts about this on the list before :)

Tony