myri10ge updates
Subsystems (2)
cover myri10ge updates
Hi Jeff,
Here are 3 minor updates of myri10ge for 2.6.22. The first one is a reduced version of the earlier nacked patch, it now limits the number of recoveries (to detect bad nics) without making the limit tunable.
1. limit the number of recoveries
2. report when the link partner is running in Myrinet mode
3. update driver version
Please apply.
Thanks!
Brice
PATCH 1/3 myri10ge: limit the number of recoveries
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default. It enables detection of defective NICs immediately since these memory parity errors are expected to happen very rarely (less than once per century*NIC).
--- drivers/net/myri10ge/myri10ge.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/net/myri10ge/myri10ge.c +10 -2
@@ -279,6 +279,8 @@module_param (myri10ge_fill_thresh, int,S_IRUGO |S_IWUSR );MODULE_PARM_DESC (myri10ge_fill_thresh,"Number of empty rx slots allowed\n" ); +static int myri10ge_reset_recover =1 ; +static int myri10ge_wcfifo =0 ;module_param (myri10ge_wcfifo, int,S_IRUGO );MODULE_PARM_DESC (myri10ge_wcfifo,"Enable WC Fifo when WC is enabled\n" );
@@ -2730,8 +2732,14 @@* For now, just report it */ reboot =myri10ge_read_reboot (mgp);printk (KERN_ERR -"myri10ge: %s: NIC rebooted (0x%x), resetting\n" , - mgp->dev->name, reboot); +"myri10ge: %s: NIC rebooted (0x%x),%s resetting\n" , + mgp->dev->name, reboot, + myri10ge_reset_recover ?" " :" not" ); +if (myri10ge_reset_recover ==0 ) +return ; + + myri10ge_reset_recover--; +/* * A rebooted nic will come back with config space as * it was after power was applied to PCIe bus.
Re: [PATCH 1/3] myri10ge: limit the number of recoveries
Quoted 8 lines · Brice Goglin
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default. It enables detection of defective NICs immediately since these memory parity errors are expected to happen very rarely (less than once per century*NIC).
Signed-off-by Brice Goglin <[email protected]>--- drivers/net/myri10ge/myri10ge.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
applied 1-3 to #upstream-fixes
PATCH 2/3 myri10ge: report when the link partner is running in Myrinet mode
In reply to Brice GoglinSince Myri-10G boards may also run in Myrinet mode instead of Ethernet, add a message when we detect that the link partner is not running in the right mode.
--- drivers/net/myri10ge/myri10ge.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
drivers/net/myri10ge/myri10ge.c +10 -5
@@ -1156,9 +1156,11 @@struct mcp_irq_data *stats = mgp->fw_stats;if (unlikely (stats->stats_updated)) { -if (mgp->link_state != stats->link_up) { - mgp->link_state = stats->link_up; -if (mgp->link_state) { +unsigned link_up =ntohl (stats->link_up); +if (mgp->link_state != link_up) { + mgp->link_state = link_up; + +if (mgp->link_state ==MXGEFW_LINK_UP ) {if (netif_msg_link (mgp)) printk(KERN_INFO "myri10ge: %s: link up\n",
@@ -1168,8 +1170,11 @@ }else {if (netif_msg_link (mgp))printk (KERN_INFO -"myri10ge: %s: link down\n" , - mgp->dev->name); +"myri10ge: %s: link %s\n" , + mgp->dev->name, + (link_up ==MXGEFW_LINK_MYRINET ? +"mismatch (Myrinet detected)" : +"down" ));netif_carrier_off (mgp->dev); mgp->link_changes++; }
PATCH 3/3 myri10ge: update driver version
In reply to Brice GoglinUpdate myri10ge driver version to 1.3.1-1.248.
--- drivers/net/myri10ge/myri10ge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/myri10ge/myri10ge.c +1 -1
@@ -71,7 +71,7 @@#include "myri10ge_mcp.h" #include "myri10ge_mcp_gen_header.h" -#define MYRI10GE_VERSION_STR "1.3.0-1.233" +#define MYRI10GE_VERSION_STR "1.3.1-1.248"MODULE_DESCRIPTION ("Myricom 10G driver (10GbE)" );MODULE_AUTHOR ("Maintainer: [email protected]" );