Skip to contentSkip to conversation

is_power_of_2-myri10ge/myri10ge.c

PATCH In review vignesh babu 2 participants 2 messages Jun 12, 2007 – Jun 13, 2007

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

vignesh babu

author
#0 lore raw

PATCH 1/1 is_power_of_2-myri10ge/myri10ge.c

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by vignesh babu <[email protected]>

---

drivers/net/myri10ge/myri10ge.c +2 -1
index b53b7ad..89da958 100644
@@ -60,6 +60,7 @@
 #include <linux/crc32.h>
 #include <linux/moduleparam.h>
 #include <linux/io.h>
+#include <linux/log2.h>
 #include <net/checksum.h>
 #include <asm/byteorder.h>
 #include <asm/io.h>

@@ -1797,7 +1798,7 @@ static int myri10ge_open(struct net_device *dev)
 	 */
 	big_pow2 = dev->mtu + ETH_HLEN + VLAN_HLEN + MXGEFW_PAD;
 	if (big_pow2 < MYRI10GE_ALLOC_SIZE / 2) {
-		while ((big_pow2 & (big_pow2 - 1)) != 0)
+		while (!is_power_of_2(big_pow2))
 			big_pow2++;
 		mgp->big_bytes = dev->mtu + ETH_HLEN + VLAN_HLEN + MXGEFW_PAD;
 	} else {
Signature · 3 lines
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"