net: remove unnecessary module_init/exit functions
Subsystems (10)
PATCH 1/1 net: remove unnecessary module_init/exit functions
Many network drivers have unnecessary empty module_init and module_exit functions. Remove them (including some that just print a message). Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.
--- drivers/net/arcnet/com20020.c | 16 ---------- drivers/net/can/sja1000/sja1000.c | 16 ---------- drivers/net/ethernet/8390/8390.c | 14 --------- drivers/net/ethernet/8390/8390p.c | 11 ------- drivers/net/ethernet/mellanox/mlxsw/pci.c | 12 -------- drivers/net/hamradio/hdlcdrv.c | 20 ------------- drivers/net/net_failover.c | 13 --------- drivers/net/wireless/ath/ath9k/common.c | 12 -------- .../realtek/rtlwifi/btcoexist/rtl_btc.c | 13 --------- drivers/net/wireless/rsi/rsi_91x_main.c | 29 ------------------- 10 files changed, 156 deletions(-)
drivers/net/arcnet/com20020.c +0 -16
@@ -401,19 +401,3 @@ EXPORT_SYMBOL(com20020_netdev_ops);MODULE_DESCRIPTION ("ARCnet COM20020 chipset core driver" );MODULE_LICENSE ("GPL" ); - -#ifdef MODULE - -static int __init com20020_module_init (void ) -{ -if (BUGLVL (D_NORMAL )) -pr_info ("%s\n" ,"COM20020 chipset support (by David Woodhouse et al.)" ); -return 0 ; -} - -static void __exit com20020_module_exit(void) -{ -} -module_init (com20020_module_init); -module_exit (com20020_module_exit); -#endif /* MODULE */
drivers/net/can/sja1000/sja1000.c +0 -16
@@ -725,19 +725,3 @@ void unregister_sja1000dev(struct net_device *dev)unregister_candev (dev); }EXPORT_SYMBOL_GPL (unregister_sja1000dev); - -static __init int sja1000_init (void ) -{ -printk (KERN_INFO "%s CAN netdevice driver\n" ,DRV_NAME ); - -return 0 ; -} - -module_init (sja1000_init); - -static __exit void sja1000_exit(void) -{ -printk (KERN_INFO "%s: driver removed\n" ,DRV_NAME ); -} - -module_exit (sja1000_exit);
drivers/net/ethernet/8390/8390.c +0 -14
@@ -86,19 +86,5 @@ void NS8390_init(struct net_device *dev, int startp) }EXPORT_SYMBOL (NS8390_init); -#if defined(MODULE ) - -static int __init ns8390_module_init (void ) -{ -return 0 ; -} - -static void __exit ns8390_module_exit(void) -{ -} - -module_init (ns8390_module_init); -module_exit (ns8390_module_exit); -#endif /* MODULE */ MODULE_DESCRIPTION ("National Semiconductor 8390 core driver" );MODULE_LICENSE ("GPL" );
drivers/net/ethernet/8390/8390p.c +0 -11
@@ -91,16 +91,5 @@ void NS8390p_init(struct net_device *dev, int startp) }EXPORT_SYMBOL (NS8390p_init); -static int __init NS8390p_init_module (void ) -{ -return 0 ; -} - -static void __exit NS8390p_cleanup_module(void) -{ -} - -module_init (NS8390p_init_module); -module_exit (NS8390p_cleanup_module);MODULE_DESCRIPTION ("National Semiconductor 8390 core for ISA driver" );MODULE_LICENSE ("GPL" );
drivers/net/ethernet/mellanox/mlxsw/pci.c +0 -12
@@ -2542,18 +2542,6 @@ void mlxsw_pci_driver_unregister(struct pci_driver *pci_driver) }EXPORT_SYMBOL (mlxsw_pci_driver_unregister); -static int __init mlxsw_pci_module_init (void ) -{ -return 0 ; -} - -static void __exit mlxsw_pci_module_exit(void) -{ -} - -module_init (mlxsw_pci_module_init); -module_exit (mlxsw_pci_module_exit); -MODULE_LICENSE ("Dual BSD/GPL" );MODULE_AUTHOR ("Jiri Pirko <[email protected]>" );MODULE_DESCRIPTION ("Mellanox switch PCI interface driver" );
drivers/net/hamradio/hdlcdrv.c +0 -20
@@ -742,26 +742,6 @@ EXPORT_SYMBOL(hdlcdrv_unregister);/* --------------------------------------------------------------------- */ -static int __init hdlcdrv_init_driver (void ) -{ -printk (KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n" ); -printk (KERN_INFO "hdlcdrv: version 0.8\n" ); -return 0 ; -} - -/* --------------------------------------------------------------------- */ - -static void __exit hdlcdrv_cleanup_driver(void) -{ -printk (KERN_INFO "hdlcdrv: cleanup\n" ); -} - -/* --------------------------------------------------------------------- */ -MODULE_AUTHOR ("Thomas M. Sailer, [email protected], [email protected]" );MODULE_DESCRIPTION ("Packet Radio network interface HDLC encoder/decoder" );MODULE_LICENSE ("GPL" ); -module_init (hdlcdrv_init_driver); -module_exit (hdlcdrv_cleanup_driver); - -/* --------------------------------------------------------------------- */
drivers/net/net_failover.c +0 -13
@@ -819,18 +819,5 @@ void net_failover_destroy(struct failover *failover) }EXPORT_SYMBOL_GPL (net_failover_destroy); -static __init int -net_failover_init (void ) -{ -return 0 ; -} -module_init (net_failover_init); - -static __exit -void net_failover_exit(void) -{ -} -module_exit (net_failover_exit); -MODULE_DESCRIPTION ("Failover driver for Paravirtual drivers" );MODULE_LICENSE ("GPL v2" );
drivers/net/wireless/ath/ath9k/common.c +0 -12
@@ -403,15 +403,3 @@ void ath9k_cmn_init_crypto(struct ath_hw *ah)ath_hw_keyreset (common, (u16 ) i); }EXPORT_SYMBOL (ath9k_cmn_init_crypto); - -static int __init ath9k_cmn_init (void ) -{ -return 0 ; -} -module_init (ath9k_cmn_init); - -static void __exit ath9k_cmn_exit(void) -{ -return ; -} -module_exit (ath9k_cmn_exit);
drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c +0 -13
@@ -519,16 +519,3 @@ MODULE_AUTHOR("Realtek WlanFAE <[email protected]>");MODULE_AUTHOR ("Larry Finger <[email protected]>" );MODULE_LICENSE ("GPL" );MODULE_DESCRIPTION ("Realtek 802.11n PCI wireless core" ); - -static int __init rtl_btcoexist_module_init (void ) -{ -return 0 ; -} - -static void __exit rtl_btcoexist_module_exit(void) -{ -return ; -} - -module_init (rtl_btcoexist_module_init); -module_exit (rtl_btcoexist_module_exit);
drivers/net/wireless/rsi/rsi_91x_main.c +0 -29
@@ -425,35 +425,6 @@ void rsi_91x_deinit(struct rsi_hw *adapter) }EXPORT_SYMBOL_GPL (rsi_91x_deinit); -/** -* rsi_91x_hal_module_init() - This function is invoked when the module is -* loaded into the kernel. -* It registers the client driver. -* @void: Void. -* -* Return: 0 on success, -1 on failure. -*/ -static int rsi_91x_hal_module_init (void ) -{ -rsi_dbg (INIT_ZONE ,"%s: Module init called\n" , __func__); -return 0 ; -} - -/** -* rsi_91x_hal_module_exit() - This function is called at the time of -* removing/unloading the module. -* It unregisters the client driver. -* @void: Void. -* -* Return: None. -*/ -static void rsi_91x_hal_module_exit (void ) -{ -rsi_dbg (INIT_ZONE ,"%s: Module exit called\n" , __func__); -} - -module_init (rsi_91x_hal_module_init); -module_exit (rsi_91x_hal_module_exit);MODULE_AUTHOR ("Redpine Signals Inc" );MODULE_DESCRIPTION ("Station driver for RSI 91x devices" );MODULE_VERSION ("0.1" );
Signature · 1 line
2.43.0
Quoted 8 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>--- drivers/net/can/sja1000/sja1000.c | 16 ----------
For drivers/net/can
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Quoted 8 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>---
drivers/net/arcnet/com20020.c| 16 ----------
For drivers/net/arcnet:
Michael
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 6 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>
For mlxsw:
Thanks
Quoted 6 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>
Quoted 10 lines
--- drivers/net/arcnet/com20020.c | 16 ---------- drivers/net/can/sja1000/sja1000.c | 16 ---------- drivers/net/ethernet/8390/8390.c | 14 --------- drivers/net/ethernet/8390/8390p.c | 11 ------- drivers/net/ethernet/mellanox/mlxsw/pci.c | 12 -------- drivers/net/hamradio/hdlcdrv.c | 20 ------------- drivers/net/net_failover.c | 13 --------- drivers/net/wireless/ath/ath9k/common.c | 12 -------- .../realtek/rtlwifi/btcoexist/rtl_btc.c | 13 ---------
For rtlwifi driver:
Quoted 6 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>
For ath9k:
Quoted 4 lines · Ethan Nelson-Moore
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.
I could be missing it, but which module does not have an module_exit function?
I ask, because maybe the author does not want to allow the module to be unloaded. We should look at the history of that module.
Andrew
Hi, Andrew,
Quoted 2 lines · Andrew Lunn
I could be missing it, but which module does not have an
module_exitfunction?
None of them. That sentence was just to explain why other instances of empty module_exit functions were not removed, in case someone else tries to do that. I didn't realize module_exit was required to unload the module at first, and other people might not either.
Ethan
Quoted 9 lines · Ethan Nelson-Moore
Hi, Andrew,
Quoted 2 lines · Andrew Lunn
I could be missing it, but which module does not have an
module_exitfunction?None of them. That sentence was just to explain why other instances of empty
module_exitfunctions were not removed, in case someone else tries to do that. I didn't realizemodule_exitwas required to unload the module at first, and other people might not either.
You need to be careful with commit messages. Reviewers read them, and think about the implications of what they say. As a result, you wasted some of my time looking for a driver which did not have an module_exit, and wondering if there was a legitimate reason for not having it, and had you just broken it....
Andrew
Quoted 5 lines · Andrew Lunn
You need to be careful with commit messages. Reviewers read them, and think about the implications of what they say. As a result, you wasted some of my time looking for a driver which did not have an
module_exit, and wondering if there was a legitimate reason for not having it, and had you just broken it....
Sorry about that. Should I send another version with a better commit message or is this patch okay the way it is?
Ethan
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 30 Jan 2026 16:42:56 -0800 you wrote:
Many network drivers have unnecessary empty
module_initandmodule_exitfunctions. Remove them (including some that just print a message). Note that if amodule_initfunction exists, amodule_exitfunction must also exist; otherwise, the module cannot be unloaded.Signed-off-by Ethan Nelson-Moore <[email protected]>[...]
Here is the summary with links:
- [net-next] net: remove unnecessary module_init/exit functions
https://git.kernel.org/netdev/net-next/c/e0221553436b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html