Skip to contentSkip to conversation

Output MFG information for HDA devices

PATCH Applied Jonathan Phénix 2 participants 4 messages Jun 14, 2007 – Jun 19, 2007

lore
Share & tools
lore

Jonathan Phénix

author
#0 lore raw

PATCH 1/1 Output MFG information for HDA devices

Hi,

this patch output information about the MFG (Modem Function Group) to the /proc/asound/card?/codec#? file. This information is important to identify if a HDA device has a modem or not.

Regards,

Jonathan Phénix
Technical specialist / Linuxant
www.linuxant.com
[email protected]

searching for changes

changeset:   5106:c63e54409236
tag:         tip
user:        root@silver
date:        Thu Jun 14 13:48:53 2007 -0400
summary:     Added MFG in HDA /proc output
pci/hda/hda_proc.c +6 -0
diff -r 96495fe7cc13 -r c63e54409236 pci/hda/hda_proc.c
@@ -250,6 +250,12 @@ static void print_codec_info(struct snd_
 	snd_iprintf(buffer, "Vendor Id: 0x%x\n", codec->vendor_id);
 	snd_iprintf(buffer, "Subsystem Id: 0x%x\n", codec->subsystem_id);
 	snd_iprintf(buffer, "Revision Id: 0x%x\n", codec->revision_id);
+
+	if (codec->mfg)
+		snd_iprintf(buffer, "Modem Function Group: 0x%x\n", codec->mfg);
+	else
+		snd_iprintf(buffer, "No Modem Function Group found\n");
+
 	if (! codec->afg)
 		return;
 	snd_iprintf(buffer, "Default PCM:\n");

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Thu, 14 Jun 2007 16:35:53 -0400,

Quoted 6 lines · Jonathan Phénix

Hi,

this patch output information about the MFG (Modem Function Group) to the /proc/asound/card?/codec#? file. This information is important to identify if a HDA device has a modem or not.

The patch looks good. Could you give your sign-off?

thanks,

Takashi

author
#2 lore raw
Quoted 9 lines · Takashi Iwai

At Thu, 14 Jun 2007 16:35:53 -0400,

Quoted 5 lines · Jonathan Phénix

Hi,

this patch output information about the MFG (Modem Function Group) to the /proc/asound/card?/codec#? file. This information is important to identify if a HDA device has a modem or not.

The patch looks good. Could you give your sign-off?

Signed-off-by Jonathan Phénix <[email protected]>

You can change "é" to "e" in my name if you prefer for technical reasons.

Quoted 3 lines

thanks,

Takashi

Regards,

Jonathan Phénix
Technical specialist / Linuxant
www.linuxant.com
[email protected]

Applied
#3 lore raw

At Tue, 19 Jun 2007 11:59:06 -0400,

Quoted 10 lines · Jonathan Phénix
Quoted 8 lines · Takashi Iwai

At Thu, 14 Jun 2007 16:35:53 -0400,

Quoted 5 lines · Jonathan Phénix

Hi,

this patch output information about the MFG (Modem Function Group) to the /proc/asound/card?/codec#? file. This information is important to identify if a HDA device has a modem or not.

Quoted 5 lines
Quoted 1 line

The patch looks good. Could you give your sign-off?

Signed-off-by Jonathan Phénix <[email protected]>

You can change "é" to "e" in my name if you prefer for technical reasons.

Thanks, applied to HG tree now.

Takashi