Skip to contentSkip to conversation

cxgb3 - fix skb->dev dereference

PATCH In review [email protected] 2 participants 2 messages May 30, 2007 – Jun 20, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/5 cxgb3 - fix skb->dev dereference

From: Divy Le Ray <[email protected]>

eth_type_trans() now sets skb->dev.
References to skb->dev should happen after it is called.

Signed-off-by Divy Le Ray <[email protected]>

---

 drivers/net/cxgb3/sge.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/cxgb3/sge.c +1 -1
index 3666586..eaa7dac 100644
@@ -1690,8 +1690,8 @@ static void rx_eth(struct adapter *adap,
 	struct port_info *pi;
 
 	skb_pull(skb, sizeof(*p) + pad);
-	skb->dev->last_rx = jiffies;
 	skb->protocol = eth_type_trans(skb, adap->port[p->iff]);
+	skb->dev->last_rx = jiffies;
 	pi = netdev_priv(skb->dev);
 	if (pi->rx_csum_offload && p->csum_valid && p->csum == 0xffff &&
 	    !p->fragment) {