Skip to contentSkip to conversation

crashkernel allocation failure #1

PATCH New Gerd Hoffmann 1 participant 1 message Jun 22, 2007 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crashkernel allocation failure #1

Hi,

The kexec crash kernel area allocation code does some effort to move the images (i.e. kernel+initrd) out of the way, so the crashkernel area can be allocated at the default location (@16m).

In case initial_images_end is not page aligned a single page in the middle of the crash kernel area is leaked though, making the whole move effort fail.

The attached patch fixed that by rounding up initial_images_end to the next page boundary.

please apply,
Gerd

arch/x86/setup.c renamed from arch/x86/setup.c.fix +1 -0
@@ -453,6 +453,7 @@
     if ( initial_images_start < xenheap_phys_end )
         initial_images_start = xenheap_phys_end;
     initial_images_end = initial_images_start + modules_length;
+    initial_images_end = (initial_images_end + PAGE_SIZE - 1) & PAGE_MASK;
 
     move_memory(initial_images_start, 
                 mod[0].mod_start, mod[mbi->mods_count-1].mod_end);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel