Skip to contentSkip to conversation

libata: kill non-sense warning message

PATCH Applied Tejun Heo 2 participants 2 messages Jun 25, 2007 – Jun 27, 2007 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: kill non-sense warning message

prereset() is now allowed to set flag for unsupported reset method. EH layer is responsible for selecting the fallback. Remove non-sense warning message.

---
 drivers/ata/libata-eh.c |    2 --
 1 file changed, 2 deletions(-)
drivers/ata/libata-eh.c +0 -2
index d807098..376f004 100644
@@ -1665,8 +1665,6 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
 
 	/* did prereset() screw up?  if so, fix up to avoid oopsing */
 	if (!reset) {
-		ata_port_printk(ap, KERN_ERR, "BUG: prereset() requested "
-				"invalid reset type\n");
 		if (softreset)
 			reset = softreset;
 		else
Applied
#1 lore raw
Quoted 14 lines · Tejun Heo

prereset() is now allowed to set flag for unsupported reset method. EH layer is responsible for selecting the fallback. Remove non-sense warning message.

---
 drivers/ata/libata-eh.c |    2 --
 1 file changed, 2 deletions(-)
drivers/ata/libata-eh.c +0 -0
index d807098..376f004 100644

drivers/ata/libata-eh.c static int ata_eh_reset(struct ata_port *ap, int classify, · line 1669

Quoted 7 lines
drivers/ata/libata-eh.c +0 -2
@@ -1665,8 +1665,6 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
 
 	/* did prereset() screw up?  if so, fix up to avoid oopsing */
 	if (!reset) {
-		ata_port_printk(ap, KERN_ERR, "BUG: prereset() requested "
-				"invalid reset type\n");
 		if (softreset)
 			reset = softreset;

applied