Skip to contentSkip to conversation

mistaken ext4_inode_bitmap for ext4_block_bitmap

PATCH New Toshiyuki Okajima 1 participant 1 message Jun 26, 2007 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mistaken ext4_inode_bitmap for ext4_block_bitmap

Hi.

I found an obvious mistake in ext4_new_blocks().
I made a fix patch for it.
Please confirm it.

This patch is for 2.6.22-rc5.

---

In ext4_new_blocks(), one of two ext4_block_bitmap() calls should be ext4_inode_bitmap() call. It is not harmful in normal processing, but it should be fixed.

---
 fs/ext4/balloc.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
fs/ext4/balloc.c +1 -1
@@ -1585,7 +1585,7 @@ allocated:
 	ret_block = grp_alloc_blk + ext4_group_first_block_no(sb, group_no);
 
 	if (in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
-	    in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
+	    in_range(ext4_inode_bitmap(sb, gdp), ret_block, num) ||
 	    in_range(ret_block, ext4_inode_table(sb, gdp),
 		     EXT4_SB(sb)->s_itb_per_group) ||
 	    in_range(ret_block + num - 1, ext4_inode_table(sb, gdp),