Skip to contentSkip to conversation

libata: kill the infamous abnormal status message

PATCH Applied Tejun Heo 3 participants 3 messages Jun 25, 2007 – Jun 27, 2007 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: kill the infamous abnormal status message

The infamous abnormal status message triggers on not so abnormal cases including empty port and even when it's being triggered on actual errors the info it provides is redundant and out of context - higher level functions will print the info in better safe later anyway.

Also, by being triggered all the time, it leads people to think that the abnormality is somehow related to all ATA and system problems they're experiencing and gives owners of healthy systems unfounded doubts about the integrity of the universe. Make it a DPRINTK and save the universe.

Signed-off-by Tejun Heo <[email protected]>
---
 include/linux/libata.h |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/ata/libata-eh.c +0 -0
include/linux/libata.h +3 -5
index 745c4f9..a3380f8 100644
@@ -1088,11 +1088,9 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
 {
 	u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
 
-	if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ))) {
-		if (ata_msg_warn(ap))
-			printk(KERN_WARNING "ATA: abnormal status 0x%X on port 0x%p\n",
-				status, ap->ioaddr.status_addr);
-	}
+	if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ)))
+		DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
+			status, ap->ioaddr.status_addr);
 
 	return status;
 }
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Mon, 25 Jun 2007 21:31:05 +0900 Tejun Heo <[email protected]> wrote:

The infamous abnormal status message triggers on not so abnormal cases including empty port and even when it's being triggered on actual errors the info it provides is redundant and out of context - higher level functions will print the info in better safe later anyway.

Quoted 7 lines

Also, by being triggered all the time, it leads people to think that the abnormality is somehow related to all ATA and system problems they're experiencing and gives owners of healthy systems unfounded doubts about the integrity of the universe. Make it a DPRINTK and save the universe.

Signed-off-by Tejun Heo <[email protected]>
Acked-by Alan Cox <[email protected]>
Applied
#2 lore raw
In reply to Tejun Heo
Quoted 11 lines · Tejun Heo

The infamous abnormal status message triggers on not so abnormal cases including empty port and even when it's being triggered on actual errors the info it provides is redundant and out of context - higher level functions will print the info in better safe later anyway.

Also, by being triggered all the time, it leads people to think that the abnormality is somehow related to all ATA and system problems they're experiencing and gives owners of healthy systems unfounded doubts about the integrity of the universe. Make it a DPRINTK and save the universe.

Quoted 4 lines
Signed-off-by Tejun Heo <[email protected]>
---
 include/linux/libata.h |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

applied