Skip to contentSkip to conversation

drm/i915: Waterproof verification of gen9 forcewake table ranges

PATCH Applied Tvrtko Ursulin 4 participants 4 messages Nov 17, 2016

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Waterproof verification of gen9 forcewake table ranges

From: Tvrtko Ursulin <[email protected]>

We have to make sure there are no holes in the table in Gen9.

---
 drivers/gpu/drm/i915/intel_uncore.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_uncore.c +2 -0
index a0944dde7c41..deb8e9e6f9ea 100644
@@ -647,6 +647,8 @@ intel_fw_table_check(struct drm_i915_private *dev_priv)
 	num_ranges = dev_priv->uncore.fw_domains_table_entries;
 
 	for (i = 0, prev = -1; i < num_ranges; i++, ranges++) {
+		WARN_ON_ONCE(IS_GEN9(dev_priv) &&
+			     (prev + 1) != (s32)ranges->start);
 		WARN_ON_ONCE(prev >= (s32)ranges->start);
 		prev = ranges->start;
 		WARN_ON_ONCE(prev >= (s32)ranges->end);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We have to make sure there are no holes in the table in Gen9.

That actually worked! ... Got any paracetamol? :)

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

✗ Fi.CI.BAT: warning for drm/i915: Waterproof verification of gen9 forcewake table ranges

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915: Waterproof verification of gen9 forcewake table ranges
URL : https://patchwork.freedesktop.org/series/15496/
State : warning

== Summary ==

Series 15496v1 drm/i915: Waterproof verification of gen9 forcewake table ranges
https://patchwork.freedesktop.org/api/1.0/series/15496/revisions/1/mbox/

Test drv_module_reload_basic:

                dmesg-warn -> PASS       (fi-skl-6770hq)
Test kms_force_connector_basic:
        Subgroup force-load-detect:
                pass       -> DMESG-WARN (fi-snb-2520m)
fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:211  dwarn:1   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

0edb25a37b8f30bf40c9db5625b7401f7fc890e9 drm-intel-nightly: 2016y-11m-17d-14h-26m-31s UTC integration manifest e4fe914 drm/i915: Waterproof verification of gen9 forcewake table ranges

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3036/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✗ Fi.CI.BAT: warning for drm/i915: Waterproof verification of gen9 forcewake table ranges

Quoted 8 lines · Patchwork

== Series Details ==

Series: drm/i915: Waterproof verification of gen9 forcewake table ranges
URL : https://patchwork.freedesktop.org/series/15496/
State : warning

== Summary ==

Quoted 8 lines

Series 15496v1 drm/i915: Waterproof verification of gen9 forcewake table ranges
https://patchwork.freedesktop.org/api/1.0/series/15496/revisions/1/mbox/

Test drv_module_reload_basic:

                dmesg-warn -> PASS       (fi-skl-6770hq)
Test kms_force_connector_basic:
        Subgroup force-load-detect:
                pass       -> DMESG-WARN (fi-snb-2520m)

Just the EDID checksum issue:

https://bugs.freedesktop.org/show_bug.cgi?id=98625

Quoted 18 lines
fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-snb-2520m     total:244  pass:211  dwarn:1   dfail:0   fail:0   skip:32
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33
Quoted 2 lines

0edb25a37b8f30bf40c9db5625b7401f7fc890e9 drm-intel-nightly: 2016y-11m-17d-14h-26m-31s UTC integration manifest e4fe914 drm/i915: Waterproof verification of gen9 forcewake table ranges

Merged to dinq, thanks for the review.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx