leds: lgm: Address review concerns
v2 cover leds: lgm: Address review concerns
Address below review concerns from Pavel:
1. Remove LEDS_BLINK Kconfig symbol.
2. Provide useful Kconfig help text for the driver.
This patch is based on "for-next" branch of kernel from below git tree:
git git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
v2:
- Fix few code quality related review concerns (Randy Dunlap).
- Further improve Kconfig help text (Pavel).
- Switch back to original copyright (pavel).
v1:
- Initial version.
Rahul Tanwar (1):
leds: lgm: Improve Kconfig help
drivers/leds/Kconfig | 5 ++--- drivers/leds/Makefile | 2 +- drivers/leds/blink/Kconfig | 28 +++++++++++++--------------- drivers/leds/blink/Makefile | 2 +- drivers/leds/blink/leds-lgm-sso.c | 4 ++-- 5 files changed, 19 insertions(+), 22 deletions(-)
--
2.17.1
________________________________
This electronic mail (including any attachments) may contain information that is privileged, confidential, and/or otherwise protected from disclosure to anyone other than its intended recipient(s). Any dissemination or use of this electronic mail or its contents (including any attachments) by persons other than the intended recipient(s) is strictly prohibited. If you have received this message in error, please notify us immediately by reply e-mail so that we may correct our internal records. Please then delete the original message (including any attachments) in its entirety.
PATCH v2 1/1 leds: lgm: Improve Kconfig help
Remove unnecessary Kconfig symbol LEDS_BLINK
Improve Kconfig help text to make it more useful.
--- drivers/leds/Kconfig | 5 ++--- drivers/leds/Makefile | 2 +- drivers/leds/blink/Kconfig | 28 +++++++++++++--------------- drivers/leds/blink/Makefile | 2 +- drivers/leds/blink/leds-lgm-sso.c | 4 ++-- 5 files changed, 19 insertions(+), 22 deletions(-)
drivers/leds/Kconfig +2 -3
@@ -928,13 +928,12 @@ config LEDS_ACER_A500 This option enables support for the Power Button LED of Acer Iconia Tab A500. +source "drivers/leds/blink/Kconfig" + comment "Flash and Torch LED drivers" source "drivers/leds/flash/Kconfig" comment "LED Triggers" source "drivers/leds/trigger/Kconfig" -comment "LED Blink" -source "drivers/leds/blink/Kconfig" - endif # NEW_LEDS
drivers/leds/Makefile +1 -1
@@ -110,4 +110,4 @@ obj-$(CONFIG_LEDS_CLASS_FLASH) += flash/ obj-$(CONFIG_LEDS_TRIGGERS) += trigger/ # LED Blink -obj-$(CONFIG_LEDS_BLINK) += blink/ +obj-y += blink/
drivers/leds/blink/Kconfig +13 -15
@@ -1,21 +1,19 @@ -menuconfig LEDS_BLINK - bool "LED Blink support" - depends on LEDS_CLASS - help - This option enables blink support for the leds class. - If unsure, say Y. - -if LEDS_BLINK - -config LEDS_BLINK_LGM - tristate "LED support for Intel LGM SoC series" +config LEDS_LGM + tristate "LED support for LGM SoC series" depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON depends on OF help - Parallel to serial conversion, which is also called SSO controller, - can drive external shift register for LED outputs. - This enables LED support for Serial Shift Output controller(SSO). + This option enables support for LEDs connected to GPIO lines on + Lightning Mountain (LGM) SoC. Lightning Mountain is a AnyWAN + gateway-on-a-chip SoC to be shipped on mid and high end home + gateways and routers. + + These LEDs are driven by a Serial Shift Output (SSO) controller. + The driver supports hardware blinking and the LEDs can be configured + to be triggered by software/CPU or by hardware. -endif # LEDS_BLINK + Say 'Y' here if you are working on LGM SoC based platform. Otherwise, + say 'N'. To compile this driver as a module, choose M here: the module + will be called leds-lgm-sso.
drivers/leds/blink/Makefile +1 -1
@@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_LEDS_BLINK_LGM) += leds-lgm-sso.o +obj-$(CONFIG_LEDS_LGM) += leds-lgm-sso.o
drivers/leds/blink/leds-lgm-sso.c +2 -2
@@ -1,8 +1,8 @@// SPDX-License-Identifier: GPL-2.0 /* -* Intel Lightning Mountain SoC LED Serial Shift Output Controller driver +* Lightning Mountain SoC LED Serial Shift Output Controller driver * -* Copyright (c) 2020 Intel Corporation. +* Copyright (c) 2021 Intel Corporation. */ #include <linux/bitfield.h>
--
2.17.1
________________________________
This electronic mail (including any attachments) may contain information that is privileged, confidential, and/or otherwise protected from disclosure to anyone other than its intended recipient(s). Any dissemination or use of this electronic mail or its contents (including any attachments) by persons other than the intended recipient(s) is strictly prohibited. If you have received this message in error, please notify us immediately by reply e-mail so that we may correct our internal records. Please then delete the original message (including any attachments) in its entirety.
Re: [PATCH v2 1/1] leds: lgm: Improve Kconfig help
Hi!
Quoted 4 lines
Remove unnecessary
KconfigsymbolLEDS_BLINK
ImproveKconfighelp text to make it more useful.Signed-off-by Rahul Tanwar <[email protected]>
Thanks for the patch, I applied it by hand.
drivers/leds/blink/leds-lgm-sso.c line 7
Quoted 11 lines
+++
b/drivers/leds/blink/leds-lgm-sso.cdrivers/leds/blink/leds-lgm-sso.c +2
-2@@ -1,8 +1,8 @@// SPDX-License-Identifier: GPL-2.0 /* -* Intel Lightning Mountain SoC LED Serial Shift Output Controller driver +* Lightning Mountain SoC LED Serial Shift Output Controller driver * -* Copyright (c) 2020 Intel Corporation. +* Copyright (c) 2021 Intel Corporation. */
Not taking this. Talk to your lawyers why.
Quoted 1 line
This electronic mail (including any attachments) may contain
information that is privileged, confidential, and/or otherwise protected from disclosure to anyone other than its intended recipient(s). Any dissemination or use of this electronic mail or its contents (including any attachments) by persons other than the intended recipient(s) is strictly prohibited. If you have received this message in error, please notify us immediately by reply e-mail so that we may correct our internal records. Please then delete the original message (including any attachments) in its entirety.
And talk to them about this, too.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek