Skip to contentSkip to conversation

fix crash in set registers in PPC gdb-stub

PATCH New Jason Wessel 1 participant 1 message Jun 29, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix crash in set registers in PPC gdb-stub

While using the gdb stub on the PPC target you cannot set registers if the machine has the power save bit set in the msr without crashing QEMU. The reason it crashes is because the cpu_loop_exit() function will get called when the gdb stub is setting the registers.

There is certainly more than one way to fix problem. I opted to add the check for the halted state to the store msr routine which is called from the the translated code or the gdb stub. The halted state is always set when the stub is active.

Jason.

---
 target-ppc/helper.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
target-ppc/helper.c +6 -4
Index: qemu/target-ppc/helper.c
===================================================================
@@ -1493,10 +1493,12 @@ void do_store_msr (CPUPPCState *env, tar
         break;
     }
     if (enter_pm) {
-        /* power save: exit cpu loop */
-        env->halted = 1;
-        env->exception_index = EXCP_HLT;
-        cpu_loop_exit();
+        if (likely(!env->halted)) {
+            /* power save: exit cpu loop */
+            env->halted = 1;
+            env->exception_index = EXCP_HLT;
+            cpu_loop_exit();
+        }
     }
 }