Skip to contentSkip to conversation

jbd lost fix?

DISCUSSION Kirill Korotaev 3 participants 3 messages Jul 2, 2007 – Jul 9, 2007

lore
Share & tools
lore
#1 lore raw

Hello,

Quoted 7 lines · Kirill Korotaev

it looks like the following fix:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92

was lost after resurrecting of the spliced checkpointing list in this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp=cdaad343b561cdeb38b0578bb038

Can you please confirm that?

Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line 890 in commit.c. Thanks for notification, I'll resend it.
BTW: How have you found this out?

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SuSE CR Labs
#2 lore raw
Quoted 10 lines · Jan Kara

Hello,

Quoted 6 lines · Kirill Korotaev

it looks like the following fix:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92

was lost after resurrecting of the spliced checkpointing list in this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp=cdaad343b561cdeb38b0578bb038

Quoted 6 lines
Quoted 1 line

Can you please confirm that?

Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line 890 in commit.c. Thanks for notification, I'll resend it.
BTW: How have you found this out?

One of OpenVZ users had an oops at journal_clean_one_cp_list+0x32/0x70
http://bugzilla.openvz.org/show_bug.cgi?id=605

which led us to the lost fix.
Since the patch existed before I didn't dare to resend it from OVZ name :)

Thanks,
Kirill