net: remove unused TCPF_TSQ_DEFERRED
Subsystems (3)
PATCH 1/1 net: remove unused TCPF_TSQ_DEFERRED
tcp_release_cb() checks for this flag, but nobody is setting it. Just kill it off.
Signed-off-by Jens Axboe <[email protected]>
---
include/linux/tcp.h +0 -1
@@ -428,7 +428,6 @@ enum tsq_enum {enum tsq_flags {TSQF_THROTTLED = (1UL <<TSQ_THROTTLED ),TSQF_QUEUED = (1UL <<TSQ_QUEUED ), -TCPF_TSQ_DEFERRED = (1UL <<TCP_TSQ_DEFERRED ),TCPF_WRITE_TIMER_DEFERRED = (1UL <<TCP_WRITE_TIMER_DEFERRED ),TCPF_DELACK_TIMER_DEFERRED = (1UL <<TCP_DELACK_TIMER_DEFERRED ),TCPF_MTU_REDUCED_DEFERRED = (1UL <<TCP_MTU_REDUCED_DEFERRED ),
net/ipv4/tcp_output.c +1 -6
@@ -1064,8 +1064,7 @@ static void tcp_tasklet_func(struct tasklet_struct *t) } } -#define TCP_DEFERRED_ALL (TCPF_TSQ_DEFERRED | \ - TCPF_WRITE_TIMER_DEFERRED | \ +#define TCP_DEFERRED_ALL (TCPF_WRITE_TIMER_DEFERRED | \ TCPF_DELACK_TIMER_DEFERRED | \ TCPF_MTU_REDUCED_DEFERRED)/**
@@ -1087,10 +1086,6 @@ void tcp_release_cb(struct sock *sk) nflags = flags & ~TCP_DEFERRED_ALL ; }while (cmpxchg (&sk->sk_tsq_flags, flags, nflags) != flags); -if (flags &TCPF_TSQ_DEFERRED ) { -tcp_tsq_write (sk); -__sock_put (sk); - }/* Here begins the tricky part : * We are called from release_sock() with : * 1) BH disabled
Signature · 1 line
Jens Axboe
Quoted 2 lines · Jens Axboe
tcp_release_cb()checks for this flag, but nobody is setting it. Just kill it off.
Should've checked closer, bit TCP_TSQ_DEFERRED can be set of course. So just disregard this one, sorry for the noise!
Signature · 1 line
Jens Axboe