Skip to contentSkip to conversation

atl1: remove write-only var in tx handler

PATCH Applied Alexey Dobriyan 3 participants 3 messages Jul 6, 2007 – Jul 10, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Alexey Dobriyan

author
#0 lore raw

PATCH 1/1 atl1: remove write-only var in tx handler

Signed-off-by Alexey Dobriyan <[email protected]>

---

 drivers/net/atl1/atl1_main.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/atl1/atl1_main.c +1 -2
@@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter *adapter)
 	struct atl1_buffer *buffer_info;
 	u16 sw_tpd_next_to_clean;
 	u16 cmb_tpd_next_to_clean;
-	u8 update = 0;
 
 	sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
 	cmb_tpd_next_to_clean = le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx);
 
 	while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
 		struct tx_packet_desc *tpd;
-		update = 1;
+
 		tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
 		buffer_info = &tpd_ring->buffer_info[sw_tpd_next_to_clean];
 		if (buffer_info->dma) {
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · On Fri, 6 Jul 2007 19:05:25 +0400 Alexey Dobriyan <[email protected]> wrote:
Signed-off-by Alexey Dobriyan <[email protected]>

---

 drivers/net/atl1/atl1_main.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/atl1/atl1_main.c +0 -1
@@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter
 *adapter) struct atl1_buffer *buffer_info;
 	u16 sw_tpd_next_to_clean;
 	u16 cmb_tpd_next_to_clean;
-	u8 update = 0;

drivers/net/atl1/atl1_main.c static void atl1_intr_tx(struct atl1_adapter · line 646

Quoted 10 lines
drivers/net/atl1/atl1_main.c +1 -1
 	sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
 	cmb_tpd_next_to_clean =
 le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx); 
 	while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
 		struct tx_packet_desc *tpd;
-		update = 1;
+
 		tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
 		buffer_info =
 &tpd_ring->buffer_info[sw_tpd_next_to_clean]; if (buffer_info->dma) {
Acked-by Jay Cliburn <[email protected]>