Skip to contentSkip to conversation

mos7720, mos7840: remove redundant urb check

PATCH New Florin Malita 1 participant 1 message Jul 16, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mos7720, mos7840: remove redundant urb check

Coverity (1709, 1710, 1711, 1712, 1713) actually flagged these as REVERSE_INULLs (NULL check performed after dereference). But looking at the other drivers I can't see any similar tests and the USB core already makes sure urb is non-null - so might as well get rid of the checks.

---

drivers/usb/serial/mos7720.c | 5 -----
drivers/usb/serial/mos7840.c | 19 -------------------

2 files changed, 24 deletions(-)
drivers/usb/serial/mos7720.c +0 -0
index 231b584..01e811b 100644
@@ -110,11 +110,6 @@ static void mos7720_interrupt_callback(struct urb *urb)
 
	dbg("%s"," : Entering\n");

- if (!urb) {
- dbg("%s","Invalid Pointer !!!!:\n");
- return;
- }
-

	switch (status) {
	case 0:
		/* success */
drivers/usb/serial/mos7840.c +0 -0
index 37f41f5..f76480f 100644
@@ -436,11 +436,6 @@ static void mos7840_control_callback(struct urb *urb)
	int result = 0;
	int status = urb->status;

- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-

	mos7840_port = (struct moschip_port *)urb->context;

	switch (status) {
@@ -525,10 +520,6 @@ static void mos7840_interrupt_callback(struct urb *urb)
	int status = urb->status;

	dbg("%s", " : Entering\n");

- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }

	switch (status) {
	case 0:
@@ -676,11 +667,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
	struct tty_struct *tty;
	int status = urb->status;

- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-

	if (status) {
		dbg("nonzero read bulk status received: %d", status);
		return;
@@ -753,11 +739,6 @@ static void mos7840_bulk_out_data_callback(struct urb *urb)
	int status = urb->status;
	int i;

- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-

	mos7840_port = (struct moschip_port *)urb->context;
	spin_lock(&mos7840_port->pool_lock);
	for (i = 0; i < NUM_URBS; i++) {