Skip to contentSkip to conversation

substream->private_data == NULL in hw_params

DISCUSSION Florian Demski 2 participants 2 messages Jul 17, 2007

lore
Share & tools
lore
#0 lore raw

Hi there,

after many reboots I finally fixed an error in a driver but I am not sure if there ain't an underlying problem which causes this error.

The initialization is done with

        struct snd_pcm *pcm;
        int err;

        if((err = snd_pcm_new(chip->pod->line6.card, (char 
*)chip->pod->line6.devname, 0, 1, 1, &pcm)) < 0)
                return err;

        pcm->private_data = chip;
        pcm->private_free = pod_cleanup_pcm;
        chip->pcm = pcm;

However in hw_param, substream->private_data is NULL and I have to get the right value with this construct:

static int snd_pod_capture_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *hw_params)

{
        int ret;
        struct snd_pod_pcm *chip = snd_pcm_substream_chip(substream);

        /* -- Florian Demski [FD] */
        /* don't ask me why, but this fixes the bug on my machine */
        if ( chip == NULL ) {
                if ( substream->pcm == NULL )
                        return -ENOMEM;
                if ( substream->pcm->private_data == NULL )
                        return -ENOMEM;
                substream->private_data = substream->pcm->private_data;
                chip = snd_pcm_substream_chip( substream );
        }
        /* -- [FD] end */

Somehow only my machine produces this error, I tried switching off SMP and PREEMPT, but with no other result.

Or is this possibly an (undocumented) feature in alsa?

I'd be happy if actually some of you experienced guys might take a look at that driver:

SVN
https://line6linux.svn.sourceforge.net/svnroot/line6linux/driver/trunk

Browse
https://line6linux.svn.sourceforge.net/viewvc/line6linux/driver/trunk/

Thanks in advance,

Florian

#1 lore raw

At Tue, 17 Jul 2007 03:00:44 +0200,

Quoted 19 lines · Florian Demski

Hi there,

after many reboots I finally fixed an error in a driver but I am not sure if there ain't an underlying problem which causes this error.

The initialization is done with

        struct snd_pcm *pcm;
        int err;

        if((err = snd_pcm_new(chip->pod->line6.card, (char 
*)chip->pod->line6.devname, 0, 1, 1, &pcm)) < 0)
                return err;

        pcm->private_data = chip;
        pcm->private_free = pod_cleanup_pcm;
        chip->pcm = pcm;
Quoted 2 lines

However in hw_param, substream->private_data is NULL and I have to get the right value with this construct:

That's weird. substream->private_data is copied from pcm->private_data at snd_pcm_open(), and never changed in another part of PCM core layer. So, my guess is somewhere in your driver overwrites it. Maybe not explicitly.

I'd check each call between open and hw_params, e.g. adding printk appropriately...

Takashi