Skip to contentSkip to conversation

leds-clevo-mail: export i8042_command()

PATCH In review Németh Márton 2 participants 3 messages Jul 17, 2007

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Németh Márton

author
#0 lore raw

PATCH 1/3 leds-clevo-mail: export i8042_command()

From: Márton Németh <[email protected]>

Export the i8042_command() function which manages the mutual exclusion with the help of the i8042_lock spinlock. This lets possible to use the i8042 hardware safely from other part of the kernel, too.

Signed-off-by Márton Németh <[email protected]>

---

drivers/input/serio/i8042.c +2 -1
diff -uprN linux-2.6.22.orig/drivers/input/serio/i8042.c linux-2.6.22/drivers/input/serio/i8042.c
@@ -208,7 +208,7 @@ static int __i8042_command(unsigned char
 	return 0;
 }
 
-static int i8042_command(unsigned char *param, int command)
+int i8042_command(unsigned char *param, int command)
 {
 	unsigned long flags;
 	int retval;

@@ -219,6 +219,7 @@ static int i8042_command(unsigned char *
 
 	return retval;
 }
+EXPORT_SYMBOL(i8042_command);
 
 /*
  * i8042_kbd_write() sends a byte out through the keyboard interface.
include/linux/i8042.h +10 -0
diff -uprN linux-2.6.22.orig/include/linux/i8042.h linux-2.6.22/include/linux/i8042.h
@@ -0,0 +1,10 @@
+
+/* There is already a header file linux/drivers/input/serio/i8042.h, so
+ * using the _LINUX prefix here as this is the <linux/i8042.h> file.
+ */
+#ifndef _LINUX_I8042_H
+#define _LINUX_I8402_H
+
+int i8042_command(unsigned char *param, int command);
+
+#endif
maintainer
#1 lore raw
Quoted 7 lines · Németh Márton

From: Márton Németh <[email protected]>

Export the i8042_command() function which manages the mutual exclusion with the help of the i8042_lock spinlock. This lets possible to use the i8042 hardware safely from other part of the kernel, too.

Signed-off-by Márton Németh <[email protected]>

Please #include <linux/i8042.h> into i8042.c. Doing so saves from nasty surprises later.

Signature · 1 line
Dmitry
author
#2 lore raw
In reply to Németh Márton

From: Márton Németh <[email protected]>

Export the i8042_command() function which manages the mutual exclusion with the help of the i8042_lock spinlock. This lets possible to use the i8042 hardware safely from other part of the kernel, too.

Signed-off-by Márton Németh <[email protected]>

---

drivers/input/serio/i8042.c +3 -1
diff -uprN linux-2.6.22.orig/drivers/input/serio/i8042.c linux-2.6.22/drivers/input/serio/i8042.c
@@ -20,6 +20,7 @@
 #include <linux/err.h>
 #include <linux/rcupdate.h>
 #include <linux/platform_device.h>
+#include <linux/i8042.h>
 
 #include <asm/io.h>
 

@@ -208,7 +209,7 @@ static int __i8042_command(unsigned char
 	return 0;
 }
 
-static int i8042_command(unsigned char *param, int command)
+int i8042_command(unsigned char *param, int command)
 {
 	unsigned long flags;
 	int retval;

@@ -219,6 +220,7 @@ static int i8042_command(unsigned char *
 
 	return retval;
 }
+EXPORT_SYMBOL(i8042_command);
 
 /*
  * i8042_kbd_write() sends a byte out through the keyboard interface.
include/linux/i8042.h +10 -0
diff -uprN linux-2.6.22.orig/include/linux/i8042.h linux-2.6.22/include/linux/i8042.h
@@ -0,0 +1,10 @@
+
+/* There is already a header file linux/drivers/input/serio/i8042.h, so
+ * using the _LINUX prefix here as this is the <linux/i8042.h> file.
+ */
+#ifndef _LINUX_I8042_H
+#define _LINUX_I8402_H
+
+int i8042_command(unsigned char *param, int command);
+
+#endif