leds-clevo-mail: driver for Clevo mail LED
PATCH 3/3 leds-clevo-mail: driver for Clevo mail LED
From: Márton Németh <[email protected]>
The driver supports the mail LED commonly found on different Clevo notebooks. The driver access the LED through the i8042 hardware and implements the support for hardware accelerated blink function.
---
drivers/leds/Kconfig +20 -0
@@ -95,6 +95,26 @@ config LEDS_COBALT help This option enables support for the front LED on Cobalt Server +config LEDS_CLEVO_MAIL + tristate "Mail LED on Clevo notebook (EXPERIMENTAL)" + depends on LEDS_CLASS && X86 && SERIO_I8042 && DMI && EXPERIMENTAL + help + This driver makes the mail LED accessible from userspace + programs through the leds subsystem. This LED can blink at + about 0.5Hz and 1Hz. + + This module can drive the mail LED for the following notebooks: + + Clevo D410J + Clevo D410V + Clevo D400V/D470V (not tested, but might work) + Clevo M540N + Clevo M5x0N (not tested, but might work) + Positivo Mobile (Clevo M5x0V) + + To compile this driver as a module, choose M here: the + module will be called leds-clevo-mail. + comment "LED Triggers" config LEDS_TRIGGERS
drivers/leds/leds-clevo-mail.c +269 -0
269 lines not on this page · raw message
drivers/leds/Makefile +1 -0
@@ -16,6 +16,7 @@ obj-$(CONFIG_LEDS_NET48XX) += leds-net4 obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o obj-$(CONFIG_LEDS_H1940) += leds-h1940.o obj-$(CONFIG_LEDS_COBALT) += leds-cobalt.o +obj-$(CONFIG_LEDS_CLEVO_MAIL) += leds-clevo-mail.o # LED Triggers obj-$(CONFIG_LEDS_TRIGGER_TIMER) += ledtrig-timer.o
Quoted 25 lines · Németh Márton
drivers/leds/leds-clevo-mail.c +25
-0+ +#define TRUE 1 +#define FALSE 0 + +#define CLEVO_MAIL_LED_OFF 0x0084 +#define CLEVO_MAIL_LED_BLINK_1HZ 0x008A +#define CLEVO_MAIL_LED_BLINK_0_5HZ 0x0083 + +#define MODULE_FNAME "leds-clevo-mail.c" +#define DRVNAME "clevo-mail-led" +#define NO_RESOURCES NULL + +#define printk_hint(fmt, args...) \ + printk(KERN_ERR MODULE_FNAME ": " fmt, ## args) + + +#define printk_dmi (field) \ + printk(KERN_ERR MODULE_FNAME \ + ": " # field "=\"%s\"\n", \ + dmi_get_system_info(field)) + + +MODULE_AUTHOR ("Márton Németh <[email protected]>" ); +MODULE_DESCRIPTION ("Clevo mail LED driver" ); +MODULE_LICENSE ("GPL" );
drivers/leds/leds-clevo-mail.c line 47
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+ +static unsigned int __initdata nodetect; +module_param_named (nodetect, nodetect, bool,0 ); +MODULE_PARM_DESC (nodetect,"Skip DMI hardware detection" ); + + +static struct platform_device *pdev; + + +static int __init led_dmi_callback (struct dmi_system_id *id) {
Functions are not statements (opening brace placement).
Quoted 56 lines
drivers/leds/leds-clevo-mail.c +56
-0+ printk(KERN_INFO MODULE_FNAME ": '%s' found\n", id->ident); +return 1 ; +} + +/** +* struct mail_led_whitelist - List of known good models +* +* Contains the known good models this driver is compatible with. +* When adding a new model try to be as strict as possible. This +* makes it possible to keep the false positives (the model is +* detected as working, but in reality it is not) as low as +* possible. +*/ +static struct dmi_system_id __initdata mail_led_whitelist[] = { + { + .callback = led_dmi_callback, + .ident ="Clevo D410J" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"VIA" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"K8N800" ), +DMI_MATCH (DMI_PRODUCT_VERSION ,"VT8204B" ) + } + }, + { + .callback = led_dmi_callback, + .ident ="Clevo M5x0N" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"CLEVO Co." ), +DMI_MATCH (DMI_PRODUCT_NAME ,"M5x0N" ) + } + }, + { + .callback = led_dmi_callback, + .ident ="Positivo Mobile" , + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR ,"CLEVO Co. " ), +DMI_MATCH (DMI_BOARD_NAME ,"M5X0V " ), +DMI_MATCH (DMI_PRODUCT_NAME ,"Positivo Mobile" ), +DMI_MATCH (DMI_PRODUCT_VERSION ,"VT6198" ) + } + }, + { + .callback = led_dmi_callback, + .ident ="Clevo D410V" , + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR ,"Clevo, Co." ), +DMI_MATCH (DMI_BOARD_NAME ,"D400V/D470V" ), +DMI_MATCH (DMI_BOARD_VERSION ,"SS78B" ), +DMI_MATCH (DMI_PRODUCT_VERSION ,"Rev. A1" ) + } + }, + { } +}; + + +static void clevo_mail_led_set(struct led_classdev *led_cdev,
drivers/leds/leds-clevo-mail.c line 113
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+ enum led_brightness value) +{ +if (value ==LED_OFF ) { +i8042_command (NULL ,CLEVO_MAIL_LED_OFF ); + }else if (value <=LED_HALF ) { +i8042_command (NULL ,CLEVO_MAIL_LED_BLINK_0_5HZ ); + }else { +i8042_command (NULL ,CLEVO_MAIL_LED_BLINK_1HZ ); + } +
I think general preference is not to use braces for single-line bodies.
Quoted 14 lines
drivers/leds/leds-clevo-mail.c +14
-0+} + +static int clevo_mail_led_blink (struct led_classdev *led_cdev, +int delay_on,int delay_off) +{ +int supported =0 ; + +if (delay_on ==500 /* ms */ && delay_off ==500 /* ms */ ) { +/* blink the led with 1Hz */ +i8042_command (NULL ,CLEVO_MAIL_LED_BLINK_1HZ ); + supported =1 ; + + }else if (delay_on ==1000 /* ms */ && delay_off ==1000 /* ms */ ) { +/* blink the led with 0.5Hz */
drivers/leds/leds-clevo-mail.c line 137
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+i8042_command (NULL ,CLEVO_MAIL_LED_BLINK_0_5HZ ); + supported =1 ; + + }else { + printk(KERN_DEBUG MODULE_FNAME +": clevo_mail_led_blink(..., %u, %u)," + " returning 0 (unsupported)\n", delay_on, delay_off); + } + +return supported;
Please return 0/-EINVAL.
Quoted 5 lines
drivers/leds/leds-clevo-mail.c +5
-0+} + + +static struct led_classdev clevo_mail_led = { + .name ="clevo::mail" ,
drivers/leds/leds-clevo-mail.c line 152
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+ .brightness_set = clevo_mail_led_set, + .blink_set = clevo_mail_led_blink, +}; + +static int __init clevo_mail_led_probe (struct platform_device *pdev) +{ +int error; + + printk(KERN_DEBUG MODULE_FNAME ": probe()\n"); +
Use pr_debug here or just kill it - it will litter users dmesgs.
Quoted 64 lines
drivers/leds/leds-clevo-mail.c +64
-0+ error =led_classdev_register (&pdev->dev, &clevo_mail_led); +return error; +} + +static int clevo_mail_led_remove (struct platform_device *pdev) +{ + + printk(KERN_DEBUG MODULE_FNAME ": remove()\n"); + +led_classdev_unregister (&clevo_mail_led); +return 0 ; +} + + + +#ifdef CONFIG_PM +static int clevo_mail_led_suspend (struct platform_device *dev, +pm_message_t state) +{ +led_classdev_suspend (&clevo_mail_led); +return 0 ; +} + +static int clevo_mail_led_resume (struct platform_device *dev) +{ +led_classdev_resume (&clevo_mail_led); +return 0 ; +} +#endif + +static struct platform_driver clevo_mail_led_driver = { + .probe = clevo_mail_led_probe, + .remove = clevo_mail_led_remove, +#ifdef CONFIG_PM + .suspend = clevo_mail_led_suspend, + .resume = clevo_mail_led_resume, +#endif + .driver = { + .name =DRVNAME , + }, +}; + + +static __init void print_hints (void ) +{ +if (!nodetect) { +printk_hint ("Current hardware not supported:\n" ); + }else { +printk_hint ("Current hardware is:\n" ); + } +printk_dmi (DMI_BIOS_VENDOR ); +printk_dmi (DMI_BIOS_VERSION ); +printk_dmi (DMI_BIOS_DATE ); +printk_dmi (DMI_SYS_VENDOR ); +printk_dmi (DMI_PRODUCT_NAME ); +printk_dmi (DMI_PRODUCT_VERSION ); +printk_dmi (DMI_PRODUCT_SERIAL ); +printk_dmi (DMI_BOARD_VENDOR ); +printk_dmi (DMI_BOARD_NAME ); +printk_dmi (DMI_BOARD_VERSION ); +if (!nodetect) { +printk_hint ("Try 'nodetect' module parameter.\n" ); + } +printk_hint ("If this driver is working with your hardware, report\n" );
drivers/leds/leds-clevo-mail.c line 226
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+printk_hint ("it through the Tracker at\n" ); +printk_hint ("http://sourceforge.net/projects/clevo-mailled/ in\n" ); +printk_hint ("order your laptop model can be added to the detection.\n" ); +printk_hint ("Please make sure to include in the report\n" ); +printk_hint (" - all lines starting with \"%s\"\n" ,MODULE_FNAME ); +printk_hint (" - the product model of the laptop and\n" ); +printk_hint (" - the color of the mail led.\n" ); +} + +static int __init led_init (void )
clevo_led_init just to be consistent with the rest of the driver?
drivers/leds/leds-clevo-mail.c line 236
Quoted 10 lines
drivers/leds/leds-clevo-mail.c +10
-0+{ +int error =0 ; +int count =0 ; + +/* Check with the help of DMI if we are running on supported hardware */ +if (!nodetect) { + count =dmi_check_system (mail_led_whitelist); + } +if (!count) { +print_hints ();
I really don't want to see that dissertation on my box. Normally we silently return if DMI data does not match. User has an option to 'force' loading the module. In that case I'd say something like 'Forcing module load. If the driver works on your hardware please report in tracker at http://sourceforge.net/projects/clevo-mailled/"
Signature · 1 line
Dmitry
From: Márton Németh <[email protected]>
The driver supports the mail LED commonly found on different Clevo notebooks. The driver access the LED through the i8042 hardware and implements the support for hardware accelerated blink function.
---
drivers/leds/Kconfig +20 -0
@@ -95,6 +95,26 @@ config LEDS_COBALT help This option enables support for the front LED on Cobalt Server +config LEDS_CLEVO_MAIL + tristate "Mail LED on Clevo notebook (EXPERIMENTAL)" + depends on LEDS_CLASS && X86 && SERIO_I8042 && DMI && EXPERIMENTAL + help + This driver makes the mail LED accessible from userspace + programs through the leds subsystem. This LED can blink at + about 0.5Hz and 1Hz. + + This module can drive the mail LED for the following notebooks: + + Clevo D410J + Clevo D410V + Clevo D400V/D470V (not tested, but might work) + Clevo M540N + Clevo M5x0N (not tested, but might work) + Positivo Mobile (Clevo M5x0V) + + To compile this driver as a module, choose M here: the + module will be called leds-clevo-mail. + comment "LED Triggers" config LEDS_TRIGGERS
drivers/leds/leds-clevo-mail.c +226 -0
226 lines not on this page · raw message
drivers/leds/Makefile +1 -0
@@ -16,6 +16,7 @@ obj-$(CONFIG_LEDS_NET48XX) += leds-net4 obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o obj-$(CONFIG_LEDS_H1940) += leds-h1940.o obj-$(CONFIG_LEDS_COBALT) += leds-cobalt.o +obj-$(CONFIG_LEDS_CLEVO_MAIL) += leds-clevo-mail.o # LED Triggers obj-$(CONFIG_LEDS_TRIGGER_TIMER) += ledtrig-timer.o