Skip to contentSkip to conversation

Merge GT/MV642xx Support into MV643xx Driver [6/8]

PATCH In review Steven J. Hill 2 participants 2 messages Jul 19, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Steven J. Hill

author
#0 lore raw

PATCH 1/1 Merge GT/MV642xx Support into MV643xx Driver [6/8]

Fix the TX bytes statistics counter to, um, actually count.

Signed-off-by Steven J. Hill <[email protected]>

---

drivers/net/mv643xx_eth.c +1 -1
@@ -1506,7 +1511,7 @@
 	spin_lock_irqsave(&mp->lock, flags);
 
 	eth_tx_submit_descs_for_skb(mp, skb);
-	stats->tx_bytes = skb->len;
+	stats->tx_bytes += skb->len;
 	stats->tx_packets++;
 	dev->trans_start = jiffies;
#1 lore raw
Quoted 8 lines · Steven J. Hill

Fix the TX bytes statistics counter to, um, actually count.

Signed-off-by Steven J. Hill <[email protected]>

---

drivers/net/mv643xx_eth.c line 1517

Quoted 8 lines
drivers/net/mv643xx_eth.c +1 -1
@@ -1506,7 +1511,7 @@
 	spin_lock_irqsave(&mp->lock, flags);
 
 	eth_tx_submit_descs_for_skb(mp, skb);
-	stats->tx_bytes = skb->len;
+	stats->tx_bytes += skb->len;
 	stats->tx_packets++;
 	dev->trans_start = jiffies;

Good fix, thanks. Please resubmit per the guidelines in Documentation/SubmittingPatches.

-Dale