85xxCDS: Skip the fake PCI bridge (FPGA)

PATCH In review Randy Vinson 1 participant 1 message Jul 20, 2007

Subsystems (2)

PowerPC Linux for PowerPC embedded PPC85XX

lore

Share & tools

lore

Randy Vinson

author

2007-07-20 18:56 UTC #0 lore raw

PATCH 1/6 85xxCDS: Skip the fake PCI bridge (FPGA)

Quoted 1 line

From 83bfbe730b1fad2ac9b22d33990e7378d920e844 Mon Sep 17 00:00:00 2001

From: Randy Vinson <[email protected]>
Date: Fri, 20 Jul 2007 11:18:26 -0700
Subject: [PATCH] 85xxCDS: Skip the fake PCI bridge (FPGA)

The 85xxCDS has an FPGA that incorrectly appears as a PCI-to-PCI bridge. This patch adds a fixup routine that will skip the bridge. With the fixup in place, the existing exclude routine is no longer needed.

Note: This code was originally part of a larger patch posted by Andy Fleming. The original patch also contained changes which handled the 85xx PCI Express host bridge. The host bridge changes have been submitted in a new form, but the FPGA changes in this patch were lost in the process.

Signed-off-by Randy Vinson <[email protected]>

---
 arch/powerpc/kernel/pci_32.c              |   13 ++++++++++++-
 arch/powerpc/platforms/85xx/mpc85xx_cds.c |   16 ----------------
 2 files changed, 12 insertions(+), 17 deletions(-)

arch/powerpc/kernel/pci_32.c +12 -1

index bfcfa14..05c2ebd 100644
@@ -80,7 +80,18 @@ fixup_cpc710_pci64(struct pci_dev* dev)
 	dev->resource[1].start = dev->resource[1].end = 0;
 	dev->resource[1].flags = 0;
 }
-DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_IBM,	PCI_DEVICE_ID_IBM_CPC710_PCI64,	fixup_cpc710_pci64);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_CPC710_PCI64, fixup_cpc710_pci64);
+
+static void __devinit skip_fake_bridge(struct pci_dev *dev)
+{
+	/* Make it an error to skip the fake bridge
+	 * in pci_setup_device() in probe.c */
+	dev->hdr_type = 0x7f;
+}
+DECLARE_PCI_FIXUP_EARLY(0x1957, 0x3fff, skip_fake_bridge);
+DECLARE_PCI_FIXUP_EARLY(0x3fff, 0x1957, skip_fake_bridge);
+DECLARE_PCI_FIXUP_EARLY(0xff3f, 0x5719, skip_fake_bridge);
+
 
 static void
 pcibios_fixup_resources(struct pci_dev *dev)

arch/powerpc/platforms/85xx/mpc85xx_cds.c +0 ~~-16~~

index 2539bb5..8046acb 100644
@@ -53,21 +53,6 @@ static volatile u8 *cadmus;
 
 #ifdef CONFIG_PCI
 
-#define ARCADIA_HOST_BRIDGE_IDSEL	17
-#define ARCADIA_2ND_BRIDGE_IDSEL	3
-
-static int mpc85xx_exclude_device(struct pci_controller *hose,
-				  u_char bus, u_char devfn)
-{
-	/* We explicitly do not go past the Tundra 320 Bridge */
-	if ((bus == 1) && (PCI_SLOT(devfn) == ARCADIA_2ND_BRIDGE_IDSEL))
-		return PCIBIOS_DEVICE_NOT_FOUND;
-	if ((bus == 0) && (PCI_SLOT(devfn) == ARCADIA_2ND_BRIDGE_IDSEL))
-		return PCIBIOS_DEVICE_NOT_FOUND;
-	else
-		return PCIBIOS_SUCCESSFUL;
-}
-
 static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
 {
 	u_char c;

@@ -226,7 +211,6 @@ static void __init mpc85xx_cds_setup_arch(void)
 			fsl_add_bridge(np, 1);
 	}
 	ppc_md.pci_irq_fixup = mpc85xx_cds_pci_irq_fixup;
-	ppc_md.pci_exclude_device = mpc85xx_exclude_device;
 #endif
 }

Signature · 1 line

1.5.2.2.549.gaeb59