Skip to contentSkip to conversation

: create hw_irq.h

M68KNOMMU Greg Ungerer 2 participants 4 messages Jul 25, 2007 IRQ

lore
Share & tools
lore
#0 lore raw

Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c

---

include/asm-m68knommu/hw_irq.h +4 -0
diff -Naur linux-2.6.22/include/asm-m68knommu/hw_irq.h linux-2.6.22-uc0/include/asm-m68knommu/hw_irq.h
@@ -0,0 +1,4 @@
+#ifndef __M68KNOMMU_HW_IRQ_H__
+#define __M68KNOMMU_HW_IRQ_H__
+
+#endif /* __M68KNOMMU_HW_IRQ_H__ */
#1 lore raw
Quoted 1 line · Greg Ungerer

Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c

hrtimer.c should be fixed not to include it instead.

#2 lore raw
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Greg Ungerer

Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c

hrtimer.c should be fixed not to include it instead.

Indirectly it is coming from include/linux/irq.h (which means that compilation of a few kernel/irq/*.c files fail on m68knommu without hw_irq.h existing too)

Can we just take out that include from there?

include/linux/irq.h 2007-07-25 22:36:28.000000000 +1000 renamed from include/linux/irq.h 2007-07-25 16:39:30.000000000 +1000 +0 -5
@@ -186,11 +186,6 @@
 #define no_irq_type            no_irq_chip
 typedef struct irq_desc                irq_desc_t;
 
-/*
- * Pick up the arch-dependent methods:
- */
-#include <asm/hw_irq.h>
-
 extern int setup_irq(unsigned int irq, struct irqaction *new);
 
 #ifdef CONFIG_GENERIC_HARDIRQS
Signature · 5 lines
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     [email protected]
SnapGear -- a Secure Computing Company      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
#3 lore raw
Quoted 9 lines · Greg Ungerer
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Greg Ungerer

Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c

hrtimer.c should be fixed not to include it instead.

Indirectly it is coming from include/linux/irq.h (which means that compilation of a few kernel/irq/*.c files fail on m68knommu without hw_irq.h existing too)

sorry. m68knommu uses genirq now and it'll have to provide hw_irq.h. Generic code just shouldn't include it direclty.

Objection to the patch taken back.

(And yes, long-term we need to fix up the mess of irq-related headers,
and Al announced he's gonna start that once 2.6.23 is out)