Skip to contentSkip to conversation

PNP: Lindent all source files

DISCUSSION Simon Arlott 4 participants 4 messages Jul 26, 2007 – Jul 27, 2007

lore
Share & tools
lore
#0 lore raw

Does anyone ever review what Lindent does? There's a fix up patch after this but it missed this at the very top of the patch and the labels.

Quoted 15 lines
Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9dd78466c956ac4b4f38e12032dc4249ccf57ad1
Commit:     9dd78466c956ac4b4f38e12032dc4249ccf57ad1
Parent:     8ec3cf7d29aef773eee5bc6cd9b0fa4d3fb42480
Author:     Bjorn Helgaas <[email protected]>
AuthorDate: Thu Jul 26 10:41:20 2007 -0700
Committer:  Linus Torvalds <[email protected]>
CommitDate: Thu Jul 26 11:35:20 2007 -0700

PNP: Lindent all source files

drivers/pnp/card.c +0 -0
index dd6384b..a379a38 100644

drivers/pnp/card.c line 14

Quoted 3 lines
drivers/pnp/card.c +2 -1
@@ -13,26 +13,28 @@
-					if (compare_pnp_id(dev->id, drv_id->devs[i].id)) {
+					if (compare_pnp_id
+					    (dev->id, drv_id->devs[i].id)) {

Leaving only the function name on a seperate line? How is that better?

drivers/pnp/card.c found: · line 336

Quoted 9 lines
drivers/pnp/card.c +1 -1
@@ -320,7 +330,7 @@ found:
 
 	return dev;
 
-err_out:
+      err_out:
 	dev->dev.driver = NULL;
 	dev->card_link = NULL;
 	return NULL;

Six spaces before a label that originally had no indentation?

The spaces it uses on lines after if (which happens all over the place) appear to go against CodingStyle's:
"Outside of comments, documentation and except in Kconfig, spaces are never used for indentation, and the above example is deliberately broken."

Signature · 1 line
Simon Arlott
#1 lore raw
Quoted 1 line · Simon Arlott

Does anyone ever review what Lindent does? There's a fix up patch after this but it missed this at the very top of the patch and the labels.

Lindent fails on several things really badly (case/labels mostly), but it is unmaintained and nobody seems to want to make it understand --i-want-linus-style-dammit options :(

Auke

#2 lore raw
In reply to Simon Arlott
Quoted 3 lines · Simon Arlott

Does anyone ever review what Lindent does? There's a fix up patch after this but it missed this at the very top of the patch and the labels.

Lindent is by no means perfect and if you use it you should always review the changes it makes by hand.
Feel free to fix it up/improve it.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#3 lore raw
In reply to Simon Arlott
Quoted 2 lines · Simon Arlott

Does anyone ever review what Lindent does? There's a fix up patch after this but it missed this at the very top of the patch and the labels.

I think you answered your own question.

Did I miss some things in the fixup patch? Yes; unfortunately, I'm not as consistent as the machine.

I started another fixup patch with the things you mentioned. Let me know if you find others, and I'll fix them, too. I'll probably wait for the next cycle to do more fixups.

Bjorn